
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in https://github.com/Homebrew/brew/pull/15136#issuecomment-1500063225 we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - https://github.com/Homebrew/brew/pull/15136#issuecomment-1500037278 - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
23 lines
589 B
Ruby
23 lines
589 B
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/move_to_extend_os"
|
|
|
|
describe RuboCop::Cop::Homebrew::MoveToExtendOS do
|
|
subject(:cop) { described_class.new }
|
|
|
|
it "registers an offense when using `OS.linux?`" do
|
|
expect_offense(<<~RUBY)
|
|
OS.linux?
|
|
^^^^^^^^^ Homebrew/MoveToExtendOS: Move `OS.linux?` and `OS.mac?` calls to `extend/os`.
|
|
RUBY
|
|
end
|
|
|
|
it "registers an offense when using `OS.mac?`" do
|
|
expect_offense(<<~RUBY)
|
|
OS.mac?
|
|
^^^^^^^ Homebrew/MoveToExtendOS: Move `OS.linux?` and `OS.mac?` calls to `extend/os`.
|
|
RUBY
|
|
end
|
|
end
|