 0b6b2f04da
			
		
	
	
		0b6b2f04da
		
			
		
	
	
	
	
		
			
			- The `brew uninstall` command has `--zap`, so let's make `brew reinstall` have parity here for a better user experience. (Requested in issue 12983.) - It feels weird that to get my new reinstall test to pass I had to add `--zap` to `cask/cmd/install.rb`, not `cask/cmd/reinstall.rb` to get the tests to pass. But the `brew reinstall --cask caffeine --zap` command worked fine all the time. The CLI argument parser from the test run was complaining about not knowing what `zap` was. As a result, `--zap` now shows up as a switch in `brew install --help` which I'm not 100% convinced is the desired UX. But I've edited the description accordingly to specify that it will only work on `reinstall` operations (and `--zap` on `install` is a no-op). ``` issyl0 at pictor in /opt/homebrew on reinstall-cask-zap ❯ brew reinstall --cask caffeine --zap ==> Downloading https://github.com/IntelliScape/caffeine/releases/download/1.1.3/Caffeine.dmg Already downloaded: /Users/issyl0/Library/Caches/Homebrew/downloads/3d6ccfdd3b8d0ab37d1c2468d6e69078c2d31d3b12bf51947c4db21e5f376af2--Caffeine.dmg ==> Implied `brew uninstall --cask caffeine` ==> Backing App 'Caffeine.app' up to '/opt/homebrew/Caskroom/caffeine/1.1.3/Caffeine.app' ==> Removing App '/Applications/Caffeine.app' ==> Dispatching zap stanza ==> Trashing files: ~/Library/Application Support/com.intelliscapesolutions.caffeine ~/Library/Preferences/com.intelliscapesolutions.caffeine.plist ~/Library/Caches/com.intelliscapesolutions.caffeine ~/Library/HTTPStoages/com.intelliscapesolutions.caffeine.binarycookies ==> Removing all staged versions of Cask 'caffeine' ==> Installing Cask caffeine ==> Moving App 'Caffeine.app' to '/Applications/Caffeine.app' 🍺 caffeine was successfully installed! ```
		
			
				
	
	
		
			263 lines
		
	
	
		
			7.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			263 lines
		
	
	
		
			7.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # typed: false
 | |
| # frozen_string_literal: true
 | |
| 
 | |
| describe Cask::Cmd::List, :cask do
 | |
|   it "lists the installed Casks in a pretty fashion" do
 | |
|     casks = %w[local-caffeine local-transmission].map { |c| Cask::CaskLoader.load(c) }
 | |
| 
 | |
|     casks.each do |c|
 | |
|       InstallHelper.install_with_caskfile(c)
 | |
|     end
 | |
| 
 | |
|     expect {
 | |
|       described_class.run
 | |
|     }.to output(<<~EOS).to_stdout
 | |
|       local-caffeine
 | |
|       local-transmission
 | |
|     EOS
 | |
|   end
 | |
| 
 | |
|   it "lists oneline" do
 | |
|     casks = %w[
 | |
|       local-caffeine
 | |
|       third-party/tap/third-party-cask
 | |
|       local-transmission
 | |
|     ].map { |c| Cask::CaskLoader.load(c) }
 | |
| 
 | |
|     casks.each do |c|
 | |
|       InstallHelper.install_with_caskfile(c)
 | |
|     end
 | |
| 
 | |
|     expect {
 | |
|       described_class.run("-1")
 | |
|     }.to output(<<~EOS).to_stdout
 | |
|       local-caffeine
 | |
|       local-transmission
 | |
|       third-party-cask
 | |
|     EOS
 | |
|   end
 | |
| 
 | |
|   it "lists full names" do
 | |
|     casks = %w[
 | |
|       local-caffeine
 | |
|       third-party/tap/third-party-cask
 | |
|       local-transmission
 | |
|     ].map { |c| Cask::CaskLoader.load(c) }
 | |
| 
 | |
|     casks.each do |c|
 | |
|       InstallHelper.install_with_caskfile(c)
 | |
|     end
 | |
| 
 | |
|     expect {
 | |
|       described_class.run("--full-name")
 | |
|     }.to output(<<~EOS).to_stdout
 | |
|       local-caffeine
 | |
|       local-transmission
 | |
|       third-party/tap/third-party-cask
 | |
|     EOS
 | |
|   end
 | |
| 
 | |
|   describe "lists versions" do
 | |
|     let(:casks) { ["local-caffeine", "local-transmission"] }
 | |
|     let(:expected_output) {
 | |
|       <<~EOS
 | |
|         local-caffeine 1.2.3
 | |
|         local-transmission 2.61
 | |
|       EOS
 | |
|     }
 | |
| 
 | |
|     before do
 | |
|       casks.map(&Cask::CaskLoader.method(:load)).each(&InstallHelper.method(:install_with_caskfile))
 | |
|     end
 | |
| 
 | |
|     it "of all installed Casks" do
 | |
|       expect {
 | |
|         described_class.run("--versions")
 | |
|       }.to output(expected_output).to_stdout
 | |
|     end
 | |
| 
 | |
|     it "of given Casks" do
 | |
|       expect {
 | |
|         described_class.run("--versions", "local-caffeine", "local-transmission")
 | |
|       }.to output(expected_output).to_stdout
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "lists json" do
 | |
|     let(:casks) { ["local-caffeine", "local-transmission", "multiple-versions", "third-party/tap/third-party-cask"] }
 | |
|     let(:expected_output) {
 | |
|       <<~EOS
 | |
|         [
 | |
|           {
 | |
|             "token": "local-caffeine",
 | |
|             "full_token": "local-caffeine",
 | |
|             "tap": "homebrew/cask",
 | |
|             "name": [
 | |
| 
 | |
|             ],
 | |
|             "desc": null,
 | |
|             "homepage": "https://brew.sh/",
 | |
|             "url": "file://#{TEST_FIXTURE_DIR}/cask/caffeine.zip",
 | |
|             "appcast": null,
 | |
|             "version": "1.2.3",
 | |
|             "versions": {
 | |
|             },
 | |
|             "installed": "1.2.3",
 | |
|             "outdated": false,
 | |
|             "sha256": "67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94",
 | |
|             "artifacts": [
 | |
|               [
 | |
|                 "Caffeine.app"
 | |
|               ],
 | |
|               {
 | |
|                 "trash": "$HOME/support/fixtures/cask/caffeine/org.example.caffeine.plist",
 | |
|                 "signal": {
 | |
|                 }
 | |
|               }
 | |
|             ],
 | |
|             "caveats": null,
 | |
|             "depends_on": {
 | |
|             },
 | |
|             "conflicts_with": null,
 | |
|             "container": null,
 | |
|             "auto_updates": null
 | |
|           },
 | |
|           {
 | |
|             "token": "local-transmission",
 | |
|             "full_token": "local-transmission",
 | |
|             "tap": "homebrew/cask",
 | |
|             "name": [
 | |
|               "Transmission"
 | |
|             ],
 | |
|             "desc": "BitTorrent client",
 | |
|             "homepage": "https://transmissionbt.com/",
 | |
|             "url": "file://#{TEST_FIXTURE_DIR}/cask/transmission-2.61.dmg",
 | |
|             "appcast": null,
 | |
|             "version": "2.61",
 | |
|             "versions": {
 | |
|             },
 | |
|             "installed": "2.61",
 | |
|             "outdated": false,
 | |
|             "sha256": "e44ffa103fbf83f55c8d0b1bea309a43b2880798dae8620b1ee8da5e1095ec68",
 | |
|             "artifacts": [
 | |
|               [
 | |
|                 "Transmission.app"
 | |
|               ]
 | |
|             ],
 | |
|             "caveats": null,
 | |
|             "depends_on": {
 | |
|             },
 | |
|             "conflicts_with": null,
 | |
|             "container": null,
 | |
|             "auto_updates": null
 | |
|           },
 | |
|           {
 | |
|             "token": "multiple-versions",
 | |
|             "full_token": "multiple-versions",
 | |
|             "tap": "homebrew/cask",
 | |
|             "name": [
 | |
| 
 | |
|             ],
 | |
|             "desc": null,
 | |
|             "homepage": "https://brew.sh/",
 | |
|             "url": "file://#{TEST_FIXTURE_DIR}/cask/caffeine.zip",
 | |
|             "appcast": null,
 | |
|             "version": "1.2.3",
 | |
|             "versions": {
 | |
|               "test_os": "1.2.0"
 | |
|             },
 | |
|             "installed": "1.2.3",
 | |
|             "outdated": false,
 | |
|             "sha256": "67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94",
 | |
|             "artifacts": [
 | |
|               [
 | |
|                 "Caffeine.app"
 | |
|               ]
 | |
|             ],
 | |
|             "caveats": null,
 | |
|             "depends_on": {
 | |
|             },
 | |
|             "conflicts_with": null,
 | |
|             "container": null,
 | |
|             "auto_updates": null
 | |
|           },
 | |
|           {
 | |
|             "token": "third-party-cask",
 | |
|             "full_token": "third-party/tap/third-party-cask",
 | |
|             "tap": "third-party/tap",
 | |
|             "name": [
 | |
| 
 | |
|             ],
 | |
|             "desc": null,
 | |
|             "homepage": "https://brew.sh/",
 | |
|             "url": "https://brew.sh/ThirdParty.dmg",
 | |
|             "appcast": null,
 | |
|             "version": "1.2.3",
 | |
|             "versions": {
 | |
|             },
 | |
|             "installed": "1.2.3",
 | |
|             "outdated": false,
 | |
|             "sha256": "8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b",
 | |
|             "artifacts": [
 | |
|               [
 | |
|                 "ThirdParty.app"
 | |
|               ]
 | |
|             ],
 | |
|             "caveats": null,
 | |
|             "depends_on": {
 | |
|             },
 | |
|             "conflicts_with": null,
 | |
|             "container": null,
 | |
|             "auto_updates": null
 | |
|           }
 | |
|         ]
 | |
|       EOS
 | |
|     }
 | |
| 
 | |
|     before do
 | |
|       casks.map(&Cask::CaskLoader.method(:load)).each(&InstallHelper.method(:install_with_caskfile))
 | |
| 
 | |
|       # Add a test OS to ensure that all cask versions are listed regardless of OS.
 | |
|       symbols = MacOS::Version::SYMBOLS.dup
 | |
|       symbols[:test_os] = "10.9"
 | |
|       stub_const("MacOS::Version::SYMBOLS", symbols)
 | |
|     end
 | |
| 
 | |
|     it "of all installed Casks" do
 | |
|       expect {
 | |
|         described_class.run("--json")
 | |
|       }.to output(expected_output).to_stdout
 | |
|     end
 | |
| 
 | |
|     it "of given Casks" do
 | |
|       expect {
 | |
|         described_class.run("--json", "local-caffeine", "local-transmission", "multiple-versions",
 | |
|                             "third-party/tap/third-party-cask")
 | |
|       }.to output(expected_output).to_stdout
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "given a set of installed Casks" do
 | |
|     let(:caffeine) { Cask::CaskLoader.load(cask_path("local-caffeine")) }
 | |
|     let(:transmission) { Cask::CaskLoader.load(cask_path("local-transmission")) }
 | |
|     let(:casks) { [caffeine, transmission] }
 | |
| 
 | |
|     it "lists the installed files for those Casks" do
 | |
|       casks.each(&InstallHelper.method(:install_without_artifacts_with_caskfile))
 | |
| 
 | |
|       transmission.artifacts.select { |a| a.is_a?(Cask::Artifact::App) }.each do |artifact|
 | |
|         artifact.install_phase(command: NeverSudoSystemCommand, force: false)
 | |
|       end
 | |
| 
 | |
|       expect {
 | |
|         described_class.run("local-transmission", "local-caffeine")
 | |
|       }.to output(<<~EOS).to_stdout
 | |
|         ==> App
 | |
|         #{transmission.config.appdir.join("Transmission.app")} (#{transmission.config.appdir.join("Transmission.app").abv})
 | |
|         ==> App
 | |
|         Missing App: #{caffeine.config.appdir.join("Caffeine.app")}
 | |
|       EOS
 | |
|     end
 | |
|   end
 | |
| end
 |