45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
58 lines
1.6 KiB
Ruby
58 lines
1.6 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "compilers"
|
|
require "os/linux/glibc"
|
|
require "system_command"
|
|
|
|
module SystemConfig
|
|
include SystemCommand::Mixin
|
|
|
|
HOST_RUBY_PATH = "/usr/bin/ruby"
|
|
|
|
class << self
|
|
def host_glibc_version
|
|
version = OS::Linux::Glibc.system_version
|
|
return "N/A" if version.null?
|
|
|
|
version
|
|
end
|
|
|
|
def host_gcc_version
|
|
gcc = Pathname.new "/usr/bin/gcc"
|
|
return "N/A" unless gcc.executable?
|
|
|
|
`#{gcc} --version 2>/dev/null`[/ (\d+\.\d+\.\d+)/, 1]
|
|
end
|
|
|
|
def formula_linked_version(formula)
|
|
return "N/A" if Homebrew::EnvConfig.no_install_from_api? && !CoreTap.instance.installed?
|
|
|
|
Formulary.factory(formula).any_installed_version || "N/A"
|
|
rescue FormulaUnavailableError
|
|
"N/A"
|
|
end
|
|
|
|
def host_ruby_version
|
|
out, _, status = system_command(HOST_RUBY_PATH, args: ["-e", "puts RUBY_VERSION"], print_stderr: false)
|
|
return "N/A" unless status.success?
|
|
|
|
out
|
|
end
|
|
|
|
def dump_verbose_config(out = $stdout)
|
|
kernel = Utils.safe_popen_read("uname", "-mors").chomp
|
|
dump_generic_verbose_config(out)
|
|
out.puts "Kernel: #{kernel}"
|
|
out.puts "OS: #{OS::Linux.os_version}"
|
|
out.puts "WSL: #{OS::Linux.wsl_version}" if OS::Linux.wsl?
|
|
out.puts "Host glibc: #{host_glibc_version}"
|
|
out.puts "/usr/bin/gcc: #{host_gcc_version}"
|
|
out.puts "/usr/bin/ruby: #{host_ruby_version}" if RUBY_PATH != HOST_RUBY_PATH
|
|
["glibc", CompilerSelector.preferred_gcc, OS::LINUX_PREFERRED_GCC_RUNTIME_FORMULA, "xorg"].each do |f|
|
|
out.puts "#{f}: #{formula_linked_version(f)}"
|
|
end
|
|
end
|
|
end
|
|
end
|