da734a30c2
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in https://github.com/Homebrew/brew/pull/15136#issuecomment-1500063225 we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - https://github.com/Homebrew/brew/pull/15136#issuecomment-1500037278 - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
60 lines
1.5 KiB
Ruby
60 lines
1.5 KiB
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/lines"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::SafePopenCommands do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "when auditing popen commands" do
|
|
it "reports and corrects `Utils.popen_read` usage" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
def install
|
|
Utils.popen_read "foo"
|
|
^^^^^^^^^^^^^^^^^^^^^^ FormulaAudit/SafePopenCommands: Use `Utils.safe_popen_read` instead of `Utils.popen_read`
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
expect_correction(<<~RUBY)
|
|
class Foo < Formula
|
|
def install
|
|
Utils.safe_popen_read "foo"
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "reports and corrects `Utils.popen_write` usage" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
def install
|
|
Utils.popen_write "foo"
|
|
^^^^^^^^^^^^^^^^^^^^^^^ FormulaAudit/SafePopenCommands: Use `Utils.safe_popen_write` instead of `Utils.popen_write`
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
expect_correction(<<~RUBY)
|
|
class Foo < Formula
|
|
def install
|
|
Utils.safe_popen_write "foo"
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "does not report an offense when `Utils.popen_read` is used in a test block" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo < Formula
|
|
def install; end
|
|
test do
|
|
Utils.popen_read "foo"
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
end
|