
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in https://github.com/Homebrew/brew/pull/15136#issuecomment-1500063225 we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - https://github.com/Homebrew/brew/pull/15136#issuecomment-1500037278 - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
25 lines
668 B
Ruby
25 lines
668 B
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/files"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::Files do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "when auditing files" do
|
|
it "reports an offense when the permissions are invalid" do
|
|
filename = Formulary.core_path("test_formula")
|
|
File.open(filename, "w") do |file|
|
|
FileUtils.chmod "-rwx", filename
|
|
|
|
expect_offense(<<~RUBY, file)
|
|
class Foo < Formula
|
|
^^^^^^^^^^^^^^^^^^^ FormulaAudit/Files: Incorrect file permissions (000): chmod +r #{filename}
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
end
|
|
end
|