45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
80 lines
1.9 KiB
Ruby
80 lines
1.9 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "macos_version"
|
|
|
|
module Homebrew
|
|
# Helper module for simulating different system configurations.
|
|
class SimulateSystem
|
|
class << self
|
|
attr_reader :arch, :os
|
|
|
|
sig {
|
|
type_parameters(:U).params(
|
|
os: Symbol,
|
|
arch: Symbol,
|
|
_block: T.proc.returns(T.type_parameter(:U)),
|
|
).returns(T.type_parameter(:U))
|
|
}
|
|
def with(os: T.unsafe(nil), arch: T.unsafe(nil), &_block)
|
|
raise ArgumentError, "At least one of `os` or `arch` must be specified." if !os && !arch
|
|
|
|
old_os = self.os
|
|
old_arch = self.arch
|
|
|
|
begin
|
|
self.os = os if os && os != current_os
|
|
self.arch = arch if arch && arch != current_arch
|
|
|
|
yield
|
|
ensure
|
|
@os = old_os
|
|
@arch = old_arch
|
|
end
|
|
end
|
|
|
|
sig { params(new_os: Symbol).void }
|
|
def os=(new_os)
|
|
os_options = [:macos, :linux, *MacOSVersion::SYMBOLS.keys]
|
|
raise "Unknown OS: #{new_os}" unless os_options.include?(new_os)
|
|
|
|
@os = new_os
|
|
end
|
|
|
|
sig { params(new_arch: Symbol).void }
|
|
def arch=(new_arch)
|
|
raise "New arch must be :arm or :intel" unless OnSystem::ARCH_OPTIONS.include?(new_arch)
|
|
|
|
@arch = new_arch
|
|
end
|
|
|
|
sig { void }
|
|
def clear
|
|
@os = @arch = nil
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def simulating_or_running_on_macos?
|
|
[:macos, *MacOSVersion::SYMBOLS.keys].include?(os)
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def simulating_or_running_on_linux?
|
|
os == :linux
|
|
end
|
|
|
|
sig { returns(Symbol) }
|
|
def current_arch
|
|
@arch || Hardware::CPU.type
|
|
end
|
|
|
|
sig { returns(Symbol) }
|
|
def current_os
|
|
os || :generic
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
require "extend/os/simulate_system"
|