b3a6e59f96
The hope is that this will be clearer and less annoying for users. A user came to us a couple weeks ago stating that it was confusing that the `brew upgrade` command printed an error when a pinned formula had a new version available and didn't get upgraded. This PR changes that message to a warning from an error. While looking into this we found that there is another message that gets printed when a package dependency doesn't get upgraded because it is pinned and that got turned into a warning from a normal message. Honestly, that should be more worrying for the user anyway; it could lead to a program not working correctly in the worst case. I also added a message to the `brew pin` command warning about potential unintended behavior if a dependency gets pinned and another package requires a newer version of it. Lastly, I added a commented out deprecation notice for the `brew upgrade --ignore-pinned` command since it's now the default.
39 lines
830 B
Ruby
39 lines
830 B
Ruby
# typed: true
|
|
# frozen_string_literal: true
|
|
|
|
require "formula"
|
|
require "cli/parser"
|
|
|
|
module Homebrew
|
|
module_function
|
|
|
|
sig { returns(CLI::Parser) }
|
|
def pin_args
|
|
Homebrew::CLI::Parser.new do
|
|
description <<~EOS
|
|
Pin the specified <formula>, preventing them from being upgraded when
|
|
issuing the `brew upgrade` <formula> command. See also `unpin`.
|
|
|
|
Note: Other packages which depend on newer versions of a pinned formula
|
|
might not install or run correctly.
|
|
EOS
|
|
|
|
named_args :installed_formula, min: 1
|
|
end
|
|
end
|
|
|
|
def pin
|
|
args = pin_args.parse
|
|
|
|
args.named.to_resolved_formulae.each do |f|
|
|
if f.pinned?
|
|
opoo "#{f.name} already pinned"
|
|
elsif !f.pinnable?
|
|
onoe "#{f.name} not installed"
|
|
else
|
|
f.pin
|
|
end
|
|
end
|
|
end
|
|
end
|