45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
53 lines
1.4 KiB
Ruby
53 lines
1.4 KiB
Ruby
# typed: true # rubocop:disable Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
class Formula
|
|
undef shared_library
|
|
undef loader_path
|
|
undef deuniversalize_machos
|
|
undef add_global_deps_to_spec
|
|
undef valid_platform?
|
|
|
|
sig { params(name: String, version: T.nilable(T.any(String, Integer))).returns(String) }
|
|
def shared_library(name, version = nil)
|
|
suffix = if version == "*" || (name == "*" && version.blank?)
|
|
"{,.*}"
|
|
elsif version.present?
|
|
".#{version}"
|
|
end
|
|
"#{name}.so#{suffix}"
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def loader_path
|
|
"$ORIGIN"
|
|
end
|
|
|
|
sig { params(targets: T.nilable(T.any(Pathname, String))).void }
|
|
def deuniversalize_machos(*targets); end
|
|
|
|
sig { params(spec: SoftwareSpec).void }
|
|
def add_global_deps_to_spec(spec)
|
|
return unless DevelopmentTools.needs_build_formulae?
|
|
|
|
@global_deps ||= begin
|
|
dependency_collector = spec.dependency_collector
|
|
related_formula_names = Set.new([
|
|
name,
|
|
*aliases,
|
|
*versioned_formulae_names,
|
|
])
|
|
[
|
|
dependency_collector.gcc_dep_if_needed(related_formula_names),
|
|
dependency_collector.glibc_dep_if_needed(related_formula_names),
|
|
].compact.freeze
|
|
end
|
|
@global_deps.each { |dep| spec.dependency_collector.add(dep) }
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def valid_platform?
|
|
requirements.none?(MacOSRequirement)
|
|
end
|
|
end
|