admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
brew/Library/Homebrew/cmd
History
Issy Long c65b3f3f13
cmd/gist-logs: Fix bug with parsing of command-line arguments 
- A user reported the following error when running `brew gist-logs`,
reproducible with any formula:

```
$ brew gist-logs rustup-init
Error: undefined method `length' for nil:NilClass
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/gist-logs.rb:145:in `gist_logs'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:102:in
```

- From what I can tell, `gist_logs_args.parse` had ended up in the wrong
  method. The `gistify_logs` method already has `formula` (ie the
  formula name) passed into it. But it's the `gist_logs` method that needs
  to do the argument parsing. This was discovered by looking at some other
  recently changed ARGV => Homebrew.args code like cmd/info.
2020-01-14 22:13:19 +00:00
..
--cache.rb
argv: move formulae to cli/args
2019-12-11 16:36:23 +05:30
--cellar.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
--env.rb
cmd: updates for command descriptions
2019-12-13 15:24:00 -05:00
--prefix.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
--repository.rb
manpages: update command usage strings
2019-08-20 08:55:54 -04:00
--version.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
analytics.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
cask.rb
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
cat.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
cleanup.rb
cmd: updates for command descriptions
2019-12-13 15:24:00 -05:00
command.rb
command: handle multiple named args
2019-12-15 00:04:45 -05:00
commands.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
config.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
deps.rb
deps: don't skip those that are both :build and :test
2019-12-27 17:35:18 -05:00
desc.rb
desc/audit: remove messages obviated by new arg parser
2019-12-13 15:23:38 -05:00
diy.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
doctor.rb
cmd: updates for command descriptions
2019-12-13 15:24:00 -05:00
fetch.rb
argv: move formulae to cli/args
2019-12-11 16:36:23 +05:30
gist-logs.rb
cmd/gist-logs: Fix bug with parsing of command-line arguments
2020-01-14 22:13:19 +00:00
help.rb
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
home.rb
argv: move formulae to cli/args
2019-12-11 16:36:23 +05:30
info.rb
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
install.rb
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
leaves.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
link.rb
cmd: improve wording of messages, spacing
2019-12-15 00:04:45 -05:00
list.rb
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
log.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
migrate.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
missing.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
options.rb
argv: move formulae to cli/args
2019-12-11 16:36:23 +05:30
outdated.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
pin.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
postinstall.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
readall.rb
cmd: updates for command descriptions
2019-12-13 15:24:00 -05:00
reinstall.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
search.rb
Fix that reason is coerced to a boolean
2019-11-20 09:49:08 -05:00
sh.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
shellenv.sh
Changes to be committed:
2019-10-31 12:25:58 +00:00
style.rb
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
switch.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
tap-info.rb
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
tap-pin.rb
Handle 2.2.0 deprecations/disableds
2019-11-06 15:25:40 +00:00
tap-unpin.rb
Handle 2.2.0 deprecations/disableds
2019-11-06 15:25:40 +00:00
tap.rb
option parser: check for extra named args
2019-12-15 00:04:45 -05:00
uninstall.rb
cmd: improve wording of messages, spacing
2019-12-15 00:04:45 -05:00
unlink.rb
Moved kegs from ARGV to args.rb
2019-11-09 11:56:47 -05:00
unpack.rb
argv: move formulae to cli/args
2019-12-11 16:36:23 +05:30
unpin.rb
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
untap.rb
cmd: improve wording of messages, spacing
2019-12-15 00:04:45 -05:00
update-report.rb
Move more code to utils/analytics.
2019-11-22 09:10:29 +00:00
update-reset.sh
shell commands: colourize messages
2019-11-21 16:18:46 -05:00
update.sh
Improve handling of *_GIT_REMOTE env vars
2020-01-13 09:43:02 +00:00
upgrade.rb
cmd/upgrade: fix pinned dependent handling.
2020-01-07 19:38:50 +00:00
uses.rb
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
vendor-install.sh
shell commands: colourize messages
2019-11-21 16:18:46 -05:00