45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
55 lines
1.6 KiB
Ruby
55 lines
1.6 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
class DevelopmentTools
|
|
class << self
|
|
sig { params(tool: T.any(String, Symbol)).returns(T.nilable(Pathname)) }
|
|
def locate(tool)
|
|
(@locate ||= {}).fetch(tool) do |key|
|
|
@locate[key] = if needs_build_formulae? &&
|
|
(binutils_path = HOMEBREW_PREFIX/"opt/binutils/bin/#{tool}").executable?
|
|
binutils_path
|
|
elsif needs_build_formulae? && (glibc_path = HOMEBREW_PREFIX/"opt/glibc/bin/#{tool}").executable?
|
|
glibc_path
|
|
elsif (homebrew_path = HOMEBREW_PREFIX/"bin/#{tool}").executable?
|
|
homebrew_path
|
|
elsif File.executable?((system_path = "/usr/bin/#{tool}"))
|
|
Pathname.new system_path
|
|
end
|
|
end
|
|
end
|
|
|
|
sig { returns(Symbol) }
|
|
def default_compiler
|
|
:gcc
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def needs_libc_formula?
|
|
return @needs_libc_formula if defined? @needs_libc_formula
|
|
|
|
@needs_libc_formula = OS::Linux::Glibc.below_ci_version?
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def needs_compiler_formula?
|
|
return @needs_compiler_formula if defined? @needs_compiler_formula
|
|
|
|
gcc = "/usr/bin/gcc"
|
|
@needs_compiler_formula = if File.exist?(gcc)
|
|
gcc_version(gcc) < OS::LINUX_GCC_CI_VERSION
|
|
else
|
|
true
|
|
end
|
|
end
|
|
|
|
sig { returns(T::Hash[String, T.nilable(String)]) }
|
|
def build_system_info
|
|
generic_build_system_info.merge({
|
|
"glibc_version" => OS::Linux::Glibc.version.to_s.presence,
|
|
"oldest_cpu_family" => Hardware.oldest_cpu.to_s,
|
|
})
|
|
end
|
|
end
|
|
end
|