1b22e16a08
Dependencies that have multiple tags (`[:build, :test]`) get sorted into multiple locations resulting in the cop always reporting an offense regardless of order.
88 lines
2.8 KiB
Ruby
88 lines
2.8 KiB
Ruby
require_relative "../../rubocops/dependency_order_cop"
|
|
|
|
describe RuboCop::Cop::NewFormulaAudit::DependencyOrder do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "depends_on" do
|
|
it "wrong conditional depends_on order" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "http://example.com"
|
|
url "http://example.com/foo-1.0.tgz"
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "foo" => :optional
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dependency "foo" (line 5) should be put before dependency "apple" (line 4)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "wrong alphabetical depends_on order" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "http://example.com"
|
|
url "http://example.com/foo-1.0.tgz"
|
|
depends_on "foo"
|
|
depends_on "bar"
|
|
^^^^^^^^^^^^^^^^ dependency "bar" (line 5) should be put before dependency "foo" (line 4)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "wrong conditional depends_on order" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "http://example.com"
|
|
url "http://example.com/foo-1.0.tgz"
|
|
head do
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "bar"
|
|
^^^^^^^^^^^^^^^^ dependency "bar" (line 6) should be put before dependency "apple" (line 5)
|
|
depends_on "foo" => :optional
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dependency "foo" (line 7) should be put before dependency "apple" (line 5)
|
|
end
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "foo" => :optional
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dependency "foo" (line 10) should be put before dependency "apple" (line 9)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "correct depends_on order for multiple tags" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "http://example.com"
|
|
url "http://example.com/foo-1.0.tgz"
|
|
depends_on "bar" => [:build, :test]
|
|
depends_on "foo" => :build
|
|
depends_on "apple"
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
|
|
context "autocorrect" do
|
|
it "wrong conditional depends_on order" do
|
|
source = <<~EOS
|
|
class Foo < Formula
|
|
homepage "http://example.com"
|
|
url "http://example.com/foo-1.0.tgz"
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "foo" => :optional
|
|
end
|
|
EOS
|
|
|
|
correct_source = <<~EOS
|
|
class Foo < Formula
|
|
homepage "http://example.com"
|
|
url "http://example.com/foo-1.0.tgz"
|
|
depends_on "foo" => :optional
|
|
depends_on "apple" if build.with? "foo"
|
|
end
|
|
EOS
|
|
|
|
corrected_source = autocorrect_source(source)
|
|
expect(corrected_source).to eq(correct_source)
|
|
end
|
|
end
|
|
end
|