45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
60 lines
1.8 KiB
Ruby
60 lines
1.8 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "tsort"
|
|
|
|
module Utils
|
|
# Topologically sortable hash map.
|
|
class TopologicalHash < Hash
|
|
include TSort
|
|
|
|
sig {
|
|
params(
|
|
packages: T.any(Cask::Cask, Formula, T::Array[T.any(Cask::Cask, Formula)]),
|
|
accumulator: TopologicalHash,
|
|
).returns(TopologicalHash)
|
|
}
|
|
def self.graph_package_dependencies(packages, accumulator = TopologicalHash.new)
|
|
packages = Array(packages)
|
|
|
|
packages.each do |cask_or_formula|
|
|
next if accumulator.key?(cask_or_formula)
|
|
|
|
if cask_or_formula.is_a?(Cask::Cask)
|
|
formula_deps = cask_or_formula.depends_on
|
|
.formula
|
|
.map { |f| Formula[f] }
|
|
cask_deps = cask_or_formula.depends_on
|
|
.cask
|
|
.map { |c| Cask::CaskLoader.load(c, config: nil) }
|
|
else
|
|
formula_deps = cask_or_formula.deps
|
|
.reject(&:build?)
|
|
.reject(&:test?)
|
|
.map(&:to_formula)
|
|
cask_deps = cask_or_formula.requirements
|
|
.filter_map(&:cask)
|
|
.map { |c| Cask::CaskLoader.load(c, config: nil) }
|
|
end
|
|
|
|
accumulator[cask_or_formula] = formula_deps + cask_deps
|
|
|
|
graph_package_dependencies(formula_deps, accumulator)
|
|
graph_package_dependencies(cask_deps, accumulator)
|
|
end
|
|
|
|
accumulator
|
|
end
|
|
|
|
private
|
|
|
|
def tsort_each_node(&block)
|
|
each_key(&block)
|
|
end
|
|
|
|
def tsort_each_child(node, &block)
|
|
fetch(node).each(&block)
|
|
end
|
|
end
|
|
end
|