3c2493f862
v0.30.0 has killed a couple of the methods being used and is throwing warnings around like candy. This switches to the new methods. Rubocops are obviously a matter of choice, and I’ve added choice here based on what was said in previous PRs and my own personal views on readability. Happy to be told to change things to different variables. For upstream detail, see: * https://github.com/bbatsov/rubocop/blob/master/relnotes/v0.30.0.md#chang es * https://github.com/bbatsov/rubocop/pull/1721/files * https://github.com/bbatsov/rubocop/pull/1655/files Closes Homebrew/homebrew#38655. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
116 lines
2.6 KiB
YAML
116 lines
2.6 KiB
YAML
# 1.8-style hash keys
|
|
Style/HashSyntax:
|
|
EnforcedStyle: hash_rockets
|
|
|
|
# ruby style guide favorite
|
|
Style/StringLiterals:
|
|
EnforcedStyle: double_quotes
|
|
|
|
# consistency with above
|
|
Style/StringLiteralsInInterpolation:
|
|
EnforcedStyle: double_quotes
|
|
|
|
# percent-x is allowed for multiline
|
|
Style/CommandLiteral:
|
|
EnforcedStyle: mixed
|
|
|
|
# paths abound, easy escape
|
|
Style/RegexpLiteral:
|
|
EnforcedStyle: slashes
|
|
|
|
# no metrics for formulas
|
|
Metrics/AbcSize:
|
|
Enabled: false
|
|
Metrics/CyclomaticComplexity:
|
|
Enabled: false
|
|
Metrics/MethodLength:
|
|
Enabled: false
|
|
Metrics/ClassLength:
|
|
Enabled: false
|
|
Metrics/PerceivedComplexity:
|
|
Enabled: false
|
|
|
|
# we often need very long lines
|
|
Metrics/LineLength:
|
|
Enabled: false
|
|
|
|
# formulas have no mandatory doc
|
|
Style/Documentation:
|
|
Enabled: false
|
|
|
|
# favor parens-less DSL-style arguments
|
|
Lint/AmbiguousOperator:
|
|
Enabled: false
|
|
Lint/AmbiguousRegexpLiteral:
|
|
Enabled: false
|
|
Lint/AssignmentInCondition:
|
|
Enabled: false
|
|
Lint/ParenthesesAsGroupedExpression:
|
|
Enabled: false
|
|
|
|
# compact style
|
|
Style/EmptyLineBetweenDefs:
|
|
AllowAdjacentOneLineDefs: true
|
|
|
|
# port numbers and such tech stuff
|
|
Style/NumericLiterals:
|
|
Enabled: false
|
|
|
|
# consistency and readability when faced with string interpolation
|
|
Style/PercentLiteralDelimiters:
|
|
PreferredDelimiters:
|
|
'%': '()'
|
|
'%i': '()'
|
|
'%q': '()'
|
|
'%Q': '()'
|
|
'%r': '{}'
|
|
'%s': '()'
|
|
'%w': '[]'
|
|
'%W': '[]'
|
|
'%x': '()'
|
|
|
|
# comma on last element is editor friendly
|
|
Style/TrailingComma:
|
|
EnforcedStyleForMultiline: comma
|
|
|
|
# conflicts with DSL-style path concatenation with `/`
|
|
Style/SpaceAroundOperators:
|
|
Enabled: false
|
|
|
|
# not a problem for typical shell users
|
|
Style/SpecialGlobalVars:
|
|
Enabled: false
|
|
|
|
# `system` is a special case and aligns on second argument
|
|
Style/AlignParameters:
|
|
Enabled: false
|
|
|
|
# counterproductive in formulas, notably within the install method
|
|
Style/GuardClause:
|
|
Enabled: false
|
|
Style/IfUnlessModifier:
|
|
Enabled: false
|
|
|
|
# dashes in filenames are typical
|
|
# TODO: enforce when rubocop has fixed this
|
|
# https://github.com/bbatsov/rubocop/issues/1545
|
|
Style/FileName:
|
|
Enabled: false
|
|
|
|
# no percent word array, being friendly to non-ruby users
|
|
# TODO: enforce when rubocop has fixed this
|
|
# https://github.com/bbatsov/rubocop/issues/1543
|
|
Style/WordArray:
|
|
Enabled: false
|
|
Style/UnneededCapitalW:
|
|
Enabled: false
|
|
|
|
# TODO: rubocop bug regarding __END__
|
|
# see https://github.com/bbatsov/rubocop/issues/1541
|
|
Style/TrailingWhitespace:
|
|
Enabled: false
|
|
Style/Tab:
|
|
Enabled: false
|
|
Style/TrailingBlankLines:
|
|
Enabled: false
|