b5f942764a
Previously, stripping arguments like `--HEAD` for dependencies failed because
that flag affects the installation prefix encoded into formula objects. The
previous implementation of `ARGV` filtering tried to contain all changes to a
single method call before the `FormulaInstaller` forks. This update spreads
things out a bit:
- The Homebrew `ARGV` extension adds a new method, `filter_for_dependencies`
which strips flags like `--HEAD`, yields to a block, then restores the
original contents of ARGV.
- The `explicitly_requested?` test, which returns true or false depending on
if a formula object is a member of `ARGV.formulae`, is now a method of
`Formula` objects.
- `FormulaInstaller` objects now execute the installation of dependencies
inside an `ARGV.filter_for_dependencies` block if the dependency was
`explicitly_requested?`.
Fixes Homebrew/homebrew#8668.
Closes Homebrew/homebrew#7724.
126 lines
2.6 KiB
Ruby
126 lines
2.6 KiB
Ruby
module HomebrewArgvExtension
|
|
def named
|
|
@named ||= reject{|arg| arg[0..0] == '-'}
|
|
end
|
|
|
|
def options_only
|
|
select {|arg| arg[0..0] == '-'}
|
|
end
|
|
|
|
def formulae
|
|
require 'formula'
|
|
@formulae ||= downcased_unique_named.map{ |name| Formula.factory name }
|
|
raise FormulaUnspecifiedError if @formulae.empty?
|
|
@formulae
|
|
end
|
|
|
|
def kegs
|
|
require 'keg'
|
|
require 'formula'
|
|
@kegs ||= downcased_unique_named.collect do |name|
|
|
n = Formula.canonical_name(name)
|
|
rack = HOMEBREW_CELLAR + if n.include? "/"
|
|
# canonical_name returns a path if it was a formula installed via a
|
|
# URL. And we only want the name. FIXME that function is insane.
|
|
Pathname.new(n).stem
|
|
else
|
|
n
|
|
end
|
|
dirs = rack.children.select{ |pn| pn.directory? } rescue []
|
|
raise NoSuchKegError.new(name) if not rack.directory? or dirs.length == 0
|
|
raise MultipleVersionsInstalledError.new(name) if dirs.length > 1
|
|
Keg.new dirs.first
|
|
end
|
|
raise KegUnspecifiedError if @kegs.empty?
|
|
@kegs
|
|
end
|
|
|
|
# self documenting perhaps?
|
|
def include? arg
|
|
@n=index arg
|
|
end
|
|
def next
|
|
at @n+1 or raise UsageError
|
|
end
|
|
|
|
def force?
|
|
flag? '--force'
|
|
end
|
|
def verbose?
|
|
flag? '--verbose' or ENV['HOMEBREW_VERBOSE']
|
|
end
|
|
def debug?
|
|
flag? '--debug' or ENV['HOMEBREW_DEBUG']
|
|
end
|
|
def quieter?
|
|
flag? '--quieter'
|
|
end
|
|
def interactive?
|
|
flag? '--interactive'
|
|
end
|
|
def one?
|
|
flag? '--1'
|
|
end
|
|
|
|
def build_head?
|
|
flag? '--HEAD'
|
|
end
|
|
|
|
def build_devel?
|
|
include? '--devel'
|
|
end
|
|
|
|
def build_universal?
|
|
include? '--universal'
|
|
end
|
|
|
|
def build_from_source?
|
|
return true if flag? '--build-from-source' or ENV['HOMEBREW_BUILD_FROM_SOURCE'] \
|
|
or not MacOS.lion? or HOMEBREW_PREFIX.to_s != '/usr/local'
|
|
options = options_only
|
|
options.delete '--universal'
|
|
not options.empty?
|
|
end
|
|
|
|
def flag? flag
|
|
options_only.each do |arg|
|
|
return true if arg == flag
|
|
next if arg[1..1] == '-'
|
|
return true if arg.include? flag[2..2]
|
|
end
|
|
return false
|
|
end
|
|
|
|
def usage
|
|
require 'cmd/help'
|
|
Homebrew.help_s
|
|
end
|
|
|
|
def filter_for_dependencies
|
|
# Clears some flags that affect installation, yields to a block, then
|
|
# restores to original state.
|
|
old_args = clone
|
|
|
|
%w[
|
|
--debug -d
|
|
--fresh
|
|
--interactive -i
|
|
--verbose -v
|
|
--HEAD
|
|
].each {|flag| delete flag}
|
|
|
|
yield
|
|
|
|
replace old_args
|
|
end
|
|
|
|
private
|
|
|
|
def downcased_unique_named
|
|
# Only lowercase names, not paths or URLs
|
|
@downcased_unique_named ||= named.map do |arg|
|
|
arg.include?("/") ? arg : arg.downcase
|
|
end.uniq
|
|
end
|
|
end
|