45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
59 lines
1.1 KiB
Ruby
59 lines
1.1 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "options"
|
|
|
|
# Shared functions for classes which can be depended upon.
|
|
module Dependable
|
|
# `:run` and `:linked` are no longer used but keep them here to avoid their
|
|
# misuse in future.
|
|
RESERVED_TAGS = [:build, :optional, :recommended, :run, :test, :linked, :implicit].freeze
|
|
|
|
attr_reader :tags
|
|
|
|
def build?
|
|
tags.include? :build
|
|
end
|
|
|
|
def optional?
|
|
tags.include? :optional
|
|
end
|
|
|
|
def recommended?
|
|
tags.include? :recommended
|
|
end
|
|
|
|
def test?
|
|
tags.include? :test
|
|
end
|
|
|
|
def implicit?
|
|
tags.include? :implicit
|
|
end
|
|
|
|
def required?
|
|
!build? && !test? && !optional? && !recommended?
|
|
end
|
|
|
|
def option_tags
|
|
tags - RESERVED_TAGS
|
|
end
|
|
|
|
def options
|
|
Options.create(option_tags)
|
|
end
|
|
|
|
def prune_from_option?(build)
|
|
return false if !optional? && !recommended?
|
|
|
|
build.without?(self)
|
|
end
|
|
|
|
def prune_if_build_and_not_dependent?(dependent, formula = nil)
|
|
return false unless build?
|
|
return dependent.installed? unless formula
|
|
|
|
dependent != formula
|
|
end
|
|
end
|