da734a30c2
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in https://github.com/Homebrew/brew/pull/15136#issuecomment-1500063225 we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - https://github.com/Homebrew/brew/pull/15136#issuecomment-1500037278 - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
47 lines
1.2 KiB
Ruby
47 lines
1.2 KiB
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/lines"
|
|
|
|
describe RuboCop::Cop::FormulaAuditStrict::MakeCheck do
|
|
subject(:cop) { described_class.new }
|
|
|
|
let(:path) { Tap::TAP_DIRECTORY/"homebrew/homebrew-core" }
|
|
|
|
before do
|
|
path.mkpath
|
|
(path/"style_exceptions").mkpath
|
|
end
|
|
|
|
def setup_style_exceptions
|
|
(path/"style_exceptions/make_check_allowlist.json").write <<~JSON
|
|
[ "bar" ]
|
|
JSON
|
|
end
|
|
|
|
it "reports an offense when formulae in homebrew/core run build-time checks" do
|
|
setup_style_exceptions
|
|
|
|
expect_offense(<<~RUBY, "#{path}/Formula/foo.rb")
|
|
class Foo < Formula
|
|
desc "foo"
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
system "make", "-j1", "test"
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ FormulaAuditStrict/MakeCheck: Formulae in homebrew/core (except e.g. cryptography, libraries) should not run build-time checks
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "reports no offenses when exempted formulae in homebrew/core run build-time checks" do
|
|
setup_style_exceptions
|
|
|
|
expect_no_offenses(<<~RUBY, "#{path}/Formula/bar.rb")
|
|
class Bar < Formula
|
|
desc "bar"
|
|
url 'https://brew.sh/bar-1.0.tgz'
|
|
system "make", "-j1", "test"
|
|
end
|
|
RUBY
|
|
end
|
|
end
|