da734a30c2
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in https://github.com/Homebrew/brew/pull/15136#issuecomment-1500063225 we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - https://github.com/Homebrew/brew/pull/15136#issuecomment-1500037278 - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
60 lines
1.5 KiB
Ruby
60 lines
1.5 KiB
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/lines"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::LicenseArrays do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "when auditing license arrays" do
|
|
it "reports no offenses for license strings" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo < Formula
|
|
desc "foo"
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
license "MIT"
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "reports no offenses for license symbols" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo < Formula
|
|
desc "foo"
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
license :public_domain
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "reports no offenses for license hashes" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo < Formula
|
|
desc "foo"
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
license any_of: ["MIT", "0BSD"]
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "reports and corrects use of a license array" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
desc "foo"
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
license ["MIT", "0BSD"]
|
|
^^^^^^^^^^^^^^^^^^^^^^^ FormulaAudit/LicenseArrays: Use `license any_of: ["MIT", "0BSD"]` instead of `license ["MIT", "0BSD"]`
|
|
end
|
|
RUBY
|
|
|
|
expect_correction(<<~RUBY)
|
|
class Foo < Formula
|
|
desc "foo"
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
license any_of: ["MIT", "0BSD"]
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
end
|