45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
114 lines
3.5 KiB
Ruby
114 lines
3.5 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "fcntl"
|
|
require "socket"
|
|
|
|
module Utils
|
|
def self.rewrite_child_error(child_error)
|
|
error = if child_error.inner["cmd"] &&
|
|
child_error.inner_class == ErrorDuringExecution
|
|
ErrorDuringExecution.new(child_error.inner["cmd"],
|
|
status: child_error.inner["status"],
|
|
output: child_error.inner["output"])
|
|
elsif child_error.inner["cmd"] &&
|
|
child_error.inner_class == BuildError
|
|
# We fill `BuildError#formula` and `BuildError#options` in later,
|
|
# when we rescue this in `FormulaInstaller#build`.
|
|
BuildError.new(nil, child_error.inner["cmd"],
|
|
child_error.inner["args"], child_error.inner["env"])
|
|
elsif child_error.inner_class == Interrupt
|
|
Interrupt.new
|
|
else
|
|
# Everything other error in the child just becomes a RuntimeError.
|
|
RuntimeError.new(child_error.message)
|
|
end
|
|
|
|
error.set_backtrace child_error.backtrace
|
|
|
|
error
|
|
end
|
|
|
|
def self.safe_fork
|
|
require "json/add/exception"
|
|
|
|
Dir.mktmpdir("homebrew", HOMEBREW_TEMP) do |tmpdir|
|
|
UNIXServer.open("#{tmpdir}/socket") do |server|
|
|
read, write = IO.pipe
|
|
|
|
pid = fork do
|
|
# bootsnap doesn't like these forked processes
|
|
ENV["HOMEBREW_NO_BOOTSNAP"] = "1"
|
|
error_pipe = server.path
|
|
ENV["HOMEBREW_ERROR_PIPE"] = error_pipe
|
|
server.close
|
|
read.close
|
|
write.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
|
|
|
|
Process::UID.change_privilege(Process.euid) if Process.euid != Process.uid
|
|
|
|
yield(error_pipe)
|
|
rescue Exception => e # rubocop:disable Lint/RescueException
|
|
error_hash = JSON.parse e.to_json
|
|
|
|
# Special case: We need to recreate ErrorDuringExecutions
|
|
# for proper error messages and because other code expects
|
|
# to rescue them further down.
|
|
if e.is_a?(ErrorDuringExecution)
|
|
error_hash["cmd"] = e.cmd
|
|
error_hash["status"] = if e.status.is_a?(Process::Status)
|
|
{
|
|
exitstatus: e.status.exitstatus,
|
|
termsig: e.status.termsig,
|
|
}
|
|
else
|
|
e.status
|
|
end
|
|
error_hash["output"] = e.output
|
|
end
|
|
|
|
write.puts error_hash.to_json
|
|
write.close
|
|
|
|
exit!
|
|
else
|
|
exit!(true)
|
|
end
|
|
|
|
pid = T.must(pid)
|
|
|
|
begin
|
|
begin
|
|
socket = server.accept_nonblock
|
|
rescue Errno::EAGAIN, Errno::EWOULDBLOCK, Errno::ECONNABORTED, Errno::EPROTO, Errno::EINTR
|
|
retry unless Process.waitpid(pid, Process::WNOHANG)
|
|
else
|
|
socket.send_io(write)
|
|
socket.close
|
|
end
|
|
write.close
|
|
data = read.read
|
|
read.close
|
|
Process.waitpid(pid) unless socket.nil?
|
|
rescue Interrupt
|
|
Process.waitpid(pid)
|
|
end
|
|
|
|
# 130 is the exit status for a process interrupted via Ctrl-C.
|
|
raise Interrupt if $CHILD_STATUS.exitstatus == 130
|
|
raise Interrupt if $CHILD_STATUS.termsig == Signal.list["INT"]
|
|
|
|
if data.present?
|
|
error_hash = JSON.parse(T.must(data.lines.first))
|
|
|
|
e = ChildProcessError.new(error_hash)
|
|
|
|
raise rewrite_child_error(e)
|
|
end
|
|
|
|
raise "Forked child process failed: #{$CHILD_STATUS}" unless $CHILD_STATUS.success?
|
|
end
|
|
end
|
|
end
|
|
end
|