17f3ee1957
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done. Also, use `ohai` and `odie` when possible as they look nicer.
79 lines
2.4 KiB
Ruby
79 lines
2.4 KiB
Ruby
require "cmd/style"
|
|
|
|
describe "brew style" do
|
|
around do |example|
|
|
begin
|
|
FileUtils.ln_s HOMEBREW_LIBRARY_PATH, HOMEBREW_LIBRARY/"Homebrew"
|
|
FileUtils.ln_s HOMEBREW_LIBRARY_PATH.parent/".rubocop.yml", HOMEBREW_LIBRARY/".rubocop_audit.yml"
|
|
FileUtils.ln_s HOMEBREW_LIBRARY_PATH.parent/".rubocop_shared.yml", HOMEBREW_LIBRARY/".rubocop_shared.yml"
|
|
|
|
example.run
|
|
ensure
|
|
FileUtils.rm_f HOMEBREW_LIBRARY/"Homebrew"
|
|
FileUtils.rm_f HOMEBREW_LIBRARY/".rubocop_audit.yml"
|
|
FileUtils.rm_f HOMEBREW_LIBRARY/".rubocop_shared.yml"
|
|
end
|
|
end
|
|
|
|
before do
|
|
allow(Homebrew).to receive(:install_bundler_gems!)
|
|
end
|
|
|
|
describe "Homebrew::check_style_json" do
|
|
let(:dir) { mktmpdir }
|
|
|
|
it "returns RubocopResults when RuboCop reports offenses" do
|
|
formula = dir/"my-formula.rb"
|
|
|
|
formula.write <<~'EOS'
|
|
class MyFormula < Formula
|
|
|
|
end
|
|
EOS
|
|
|
|
rubocop_result = Homebrew::Style.check_style_json([formula])
|
|
|
|
expect(rubocop_result.file_offenses(formula.realpath.to_s).map(&:message))
|
|
.to include("Extra empty line detected at class body beginning.")
|
|
end
|
|
|
|
it "corrected offense output format" do
|
|
formula = dir/"my-formula-2.rb"
|
|
|
|
formula.write <<~EOS
|
|
class MyFormula2 < Formula
|
|
desc "Test formula"
|
|
homepage "https://foo.org"
|
|
url "https://foo.org/foo-1.7.5.tgz"
|
|
sha256 "cc692fb9dee0cc288757e708fc1a3b6b56ca1210ca181053a371cb11746969da"
|
|
|
|
depends_on "foo"
|
|
depends_on "bar-config" => :build
|
|
|
|
test do
|
|
assert_equal 5, 5
|
|
end
|
|
end
|
|
EOS
|
|
options = { fix: true, only_cops: ["NewFormulaAudit/DependencyOrder"], realpath: true }
|
|
rubocop_result = Homebrew::Style.check_style_json([formula], options)
|
|
offense_string = rubocop_result.file_offenses(formula.realpath).first.to_s
|
|
expect(offense_string).to match(/\[Corrected\]/)
|
|
end
|
|
end
|
|
|
|
describe "Homebrew::check_style_and_print" do
|
|
let(:dir) { mktmpdir }
|
|
|
|
it "returns false for conforming file with only audit-level violations" do
|
|
# This file is known to use non-rocket hashes and other things that trigger audit,
|
|
# but not regular, cop violations
|
|
target_file = HOMEBREW_LIBRARY_PATH/"utils.rb"
|
|
|
|
rubocop_result = Homebrew::Style.check_style_and_print([target_file])
|
|
|
|
expect(rubocop_result).to eq false
|
|
end
|
|
end
|
|
end
|