45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
51 lines
1.5 KiB
Ruby
51 lines
1.5 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "compilers"
|
|
|
|
class LinkageChecker
|
|
# Libraries provided by glibc and gcc.
|
|
SYSTEM_LIBRARY_ALLOWLIST = %w[
|
|
ld-linux-x86-64.so.2
|
|
ld-linux-aarch64.so.1
|
|
libanl.so.1
|
|
libatomic.so.1
|
|
libc.so.6
|
|
libdl.so.2
|
|
libm.so.6
|
|
libmvec.so.1
|
|
libnss_files.so.2
|
|
libpthread.so.0
|
|
libresolv.so.2
|
|
librt.so.1
|
|
libthread_db.so.1
|
|
libutil.so.1
|
|
libgcc_s.so.1
|
|
libgomp.so.1
|
|
libstdc++.so.6
|
|
libquadmath.so.0
|
|
].freeze
|
|
|
|
private
|
|
|
|
def check_dylibs(rebuild_cache:)
|
|
generic_check_dylibs(rebuild_cache:)
|
|
|
|
# glibc and gcc are implicit dependencies.
|
|
# No other linkage to system libraries is expected or desired.
|
|
@unwanted_system_dylibs = @system_dylibs.reject do |s|
|
|
SYSTEM_LIBRARY_ALLOWLIST.include? File.basename(s)
|
|
end
|
|
|
|
# We build all formulae with an RPATH that includes the gcc formula's runtime lib directory.
|
|
# See: https://github.com/Homebrew/brew/blob/e689cc07/Library/Homebrew/extend/os/linux/extend/ENV/super.rb#L53
|
|
# This results in formulae showing linkage with gcc whenever it is installed, even if no dependency is declared.
|
|
# See discussions at:
|
|
# https://github.com/Homebrew/brew/pull/13659
|
|
# https://github.com/Homebrew/brew/pull/13796
|
|
# TODO: Find a nicer way to handle this. (e.g. examining the ELF file to determine the required libstdc++.)
|
|
@undeclared_deps.delete("gcc")
|
|
@indirect_deps.delete("gcc")
|
|
end
|
|
end
|