
This reworks the new `Pypi` JSON API implementation to use `Json::find_versions` in `Pypi::find_versions`, borrowing some of the approach from the `Crate` strategy. Besides that, this pares down the fields in the `::generate_input_values` return hash to only `:url`, as we're not using a generated regex to match version information in this setup. This adds a `provided_content` parameter to `::find_versions` as part of this process and I will expand the `Pypi` tests to increase coverage (like the `Crates` tests) in a later PR. 75% of `Pypi` checks are failing at the moment (with some returning inaccurate version information), so the current priority is getting this fix merged in the short-term.
37 lines
955 B
Ruby
37 lines
955 B
Ruby
# frozen_string_literal: true
|
|
|
|
require "livecheck/strategy"
|
|
|
|
RSpec.describe Homebrew::Livecheck::Strategy::Pypi do
|
|
subject(:pypi) { described_class }
|
|
|
|
let(:pypi_url) { "https://files.pythonhosted.org/packages/ab/cd/efg/example-package-1.2.3.tar.gz" }
|
|
let(:non_pypi_url) { "https://brew.sh/test" }
|
|
|
|
let(:generated) do
|
|
{
|
|
url: "https://pypi.org/pypi/example-package/json",
|
|
}
|
|
end
|
|
|
|
describe "::match?" do
|
|
it "returns true for a PyPI URL" do
|
|
expect(pypi.match?(pypi_url)).to be true
|
|
end
|
|
|
|
it "returns false for a non-PyPI URL" do
|
|
expect(pypi.match?(non_pypi_url)).to be false
|
|
end
|
|
end
|
|
|
|
describe "::generate_input_values" do
|
|
it "returns a hash containing url and regex for an PyPI URL" do
|
|
expect(pypi.generate_input_values(pypi_url)).to eq(generated)
|
|
end
|
|
|
|
it "returns an empty hash for a non-PyPI URL" do
|
|
expect(pypi.generate_input_values(non_pypi_url)).to eq({})
|
|
end
|
|
end
|
|
end
|