 1474806527
			
		
	
	
		1474806527
		
			
		
	
	
	
	
		
			
			We already had `HOMEBREW_FORBIDDEN_LICENSES` but this commit adds `HOMEBREW_FORBIDDEN_CASKS`, `HOMEBREW_FORBIDDEN_FORMULAE` and `HOMEBREW_FORBIDDEN_TAPS` for also forbidding those. Relatedly, add `HOMEBREW_FORBIDDEN_OWNER` and `HOMEBREW_FORBIDDEN_OWNER_CONTACT` to allow customising these messages. There were no existing tests for `HOMEBREW_FORBIDDEN_LICENSES` so have added more tests for all of these checks. Co-authored-by: Bo Anderson <mail@boanderson.me>
		
			
				
	
	
		
			401 lines
		
	
	
		
			14 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			401 lines
		
	
	
		
			14 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| RSpec.describe Cask::Installer, :cask do
 | |
|   describe "install" do
 | |
|     it "downloads and installs a nice fresh Cask" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
| 
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version)).to be_a_directory
 | |
|       expect(caffeine.config.appdir.join("Caffeine.app")).to be_a_directory
 | |
|     end
 | |
| 
 | |
|     it "works with HFS+ dmg-based Casks" do
 | |
|       asset = Cask::CaskLoader.load(cask_path("container-dmg"))
 | |
| 
 | |
|       described_class.new(asset).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("container-dmg", asset.version)).to be_a_directory
 | |
|       expect(asset.config.appdir.join("container")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "works with tar-gz-based Casks" do
 | |
|       asset = Cask::CaskLoader.load(cask_path("container-tar-gz"))
 | |
| 
 | |
|       described_class.new(asset).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("container-tar-gz", asset.version)).to be_a_directory
 | |
|       expect(asset.config.appdir.join("container")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "works with xar-based Casks" do
 | |
|       asset = Cask::CaskLoader.load(cask_path("container-xar"))
 | |
| 
 | |
|       described_class.new(asset).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("container-xar", asset.version)).to be_a_directory
 | |
|       expect(asset.config.appdir.join("container")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "works with pure bzip2-based Casks" do
 | |
|       asset = Cask::CaskLoader.load(cask_path("container-bzip2"))
 | |
| 
 | |
|       described_class.new(asset).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("container-bzip2", asset.version)).to be_a_directory
 | |
|       expect(asset.config.appdir.join("container")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "works with pure gzip-based Casks" do
 | |
|       asset = Cask::CaskLoader.load(cask_path("container-gzip"))
 | |
| 
 | |
|       described_class.new(asset).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("container-gzip", asset.version)).to be_a_directory
 | |
|       expect(asset.config.appdir.join("container")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "blows up on a bad checksum" do
 | |
|       bad_checksum = Cask::CaskLoader.load(cask_path("bad-checksum"))
 | |
|       expect do
 | |
|         described_class.new(bad_checksum).install
 | |
|       end.to raise_error(ChecksumMismatchError)
 | |
|     end
 | |
| 
 | |
|     it "blows up on a missing checksum" do
 | |
|       missing_checksum = Cask::CaskLoader.load(cask_path("missing-checksum"))
 | |
|       expect do
 | |
|         described_class.new(missing_checksum).install
 | |
|       end.to output(/Cannot verify integrity/).to_stderr
 | |
|     end
 | |
| 
 | |
|     it "installs fine if sha256 :no_check is used" do
 | |
|       no_checksum = Cask::CaskLoader.load(cask_path("no-checksum"))
 | |
| 
 | |
|       described_class.new(no_checksum).install
 | |
| 
 | |
|       expect(no_checksum).to be_installed
 | |
|     end
 | |
| 
 | |
|     it "fails to install if sha256 :no_check is used with --require-sha" do
 | |
|       no_checksum = Cask::CaskLoader.load(cask_path("no-checksum"))
 | |
|       expect do
 | |
|         described_class.new(no_checksum, require_sha: true).install
 | |
|       end.to raise_error(/--require-sha/)
 | |
|     end
 | |
| 
 | |
|     it "installs fine if sha256 :no_check is used with --require-sha and --force" do
 | |
|       no_checksum = Cask::CaskLoader.load(cask_path("no-checksum"))
 | |
| 
 | |
|       described_class.new(no_checksum, require_sha: true, force: true).install
 | |
| 
 | |
|       expect(no_checksum).to be_installed
 | |
|     end
 | |
| 
 | |
|     it "prints caveats if they're present" do
 | |
|       with_caveats = Cask::CaskLoader.load(cask_path("with-caveats"))
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(with_caveats).install
 | |
|       end.to output(/Here are some things you might want to know/).to_stdout
 | |
| 
 | |
|       expect(with_caveats).to be_installed
 | |
|     end
 | |
| 
 | |
|     it "prints installer :manual instructions when present" do
 | |
|       with_installer_manual = Cask::CaskLoader.load(cask_path("with-installer-manual"))
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(with_installer_manual).install
 | |
|       end.to output(
 | |
|         <<~EOS,
 | |
|           ==> Downloading file://#{HOMEBREW_LIBRARY_PATH}/test/support/fixtures/cask/caffeine.zip
 | |
|           ==> Installing Cask with-installer-manual
 | |
|           Cask with-installer-manual only provides a manual installer. To run it and complete the installation:
 | |
|             open #{with_installer_manual.staged_path.join("Caffeine.app")}
 | |
|           🍺  with-installer-manual was successfully installed!
 | |
|         EOS
 | |
|       ).to_stdout
 | |
| 
 | |
|       expect(with_installer_manual).to be_installed
 | |
|     end
 | |
| 
 | |
|     it "does not extract __MACOSX directories from zips" do
 | |
|       with_macosx_dir = Cask::CaskLoader.load(cask_path("with-macosx-dir"))
 | |
| 
 | |
|       described_class.new(with_macosx_dir).install
 | |
| 
 | |
|       expect(with_macosx_dir.staged_path.join("__MACOSX")).not_to be_a_directory
 | |
|     end
 | |
| 
 | |
|     it "allows already-installed Casks which auto-update to be installed if force is provided" do
 | |
|       with_auto_updates = Cask::CaskLoader.load(cask_path("auto-updates"))
 | |
| 
 | |
|       expect(with_auto_updates).not_to be_installed
 | |
| 
 | |
|       described_class.new(with_auto_updates).install
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(with_auto_updates, force: true).install
 | |
|       end.not_to raise_error
 | |
|     end
 | |
| 
 | |
|     it "allows already-installed Casks to be installed if force is provided" do
 | |
|       transmission = Cask::CaskLoader.load(cask_path("local-transmission"))
 | |
| 
 | |
|       expect(transmission).not_to be_installed
 | |
| 
 | |
|       described_class.new(transmission).install
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(transmission, force: true).install
 | |
|       end.not_to raise_error
 | |
|     end
 | |
| 
 | |
|     it "works naked-pkg-based Casks" do
 | |
|       naked_pkg = Cask::CaskLoader.load(cask_path("container-pkg"))
 | |
| 
 | |
|       described_class.new(naked_pkg).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("container-pkg", naked_pkg.version, "container.pkg")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "works properly with an overridden container :type" do
 | |
|       naked_executable = Cask::CaskLoader.load(cask_path("naked-executable"))
 | |
| 
 | |
|       described_class.new(naked_executable).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("naked-executable", naked_executable.version, "naked_executable")).to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "works fine with a nested container" do
 | |
|       nested_app = Cask::CaskLoader.load(cask_path("nested-app"))
 | |
| 
 | |
|       described_class.new(nested_app).install
 | |
| 
 | |
|       expect(nested_app.config.appdir.join("MyNestedApp.app")).to be_a_directory
 | |
|     end
 | |
| 
 | |
|     it "generates and finds a timestamped metadata directory for an installed Cask" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
| 
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       m_path = caffeine.metadata_timestamped_path(timestamp: :now, create: true)
 | |
|       expect(caffeine.metadata_timestamped_path(timestamp: :latest)).to eq(m_path)
 | |
|     end
 | |
| 
 | |
|     it "generates and finds a metadata subdirectory for an installed Cask" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
| 
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       subdir_name = "Casks"
 | |
|       m_subdir = caffeine.metadata_subdir(subdir_name, timestamp: :now, create: true)
 | |
|       expect(caffeine.metadata_subdir(subdir_name, timestamp: :latest)).to eq(m_subdir)
 | |
|     end
 | |
| 
 | |
|     it "don't print cask installed message with --quiet option" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
|       expect do
 | |
|         described_class.new(caffeine, quiet: true).install
 | |
|       end.to output(nil).to_stdout
 | |
|     end
 | |
| 
 | |
|     it "does NOT generate LATEST_DOWNLOAD_SHA256 file for installed Cask without version :latest" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
| 
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       expect(caffeine.download_sha_path).not_to be_a_file
 | |
|     end
 | |
| 
 | |
|     it "generates and finds LATEST_DOWNLOAD_SHA256 file for installed Cask with version :latest" do
 | |
|       latest_cask = Cask::CaskLoader.load(cask_path("version-latest"))
 | |
| 
 | |
|       described_class.new(latest_cask).install
 | |
| 
 | |
|       expect(latest_cask.download_sha_path).to be_a_file
 | |
|     end
 | |
| 
 | |
|     context "when loaded from the api and caskfile is required" do
 | |
|       let(:path) { cask_path("local-caffeine") }
 | |
|       let(:content) { File.read(path) }
 | |
| 
 | |
|       it "installs cask" do
 | |
|         source_caffeine = Cask::CaskLoader.load(path)
 | |
|         expect(Homebrew::API::Cask).to receive(:source_download).once.and_return(source_caffeine)
 | |
| 
 | |
|         caffeine = Cask::CaskLoader.load(path)
 | |
|         expect(caffeine).to receive(:loaded_from_api?).once.and_return(true)
 | |
|         expect(caffeine).to receive(:caskfile_only?).once.and_return(true)
 | |
| 
 | |
|         described_class.new(caffeine).install
 | |
|         expect(Cask::CaskLoader.load(path)).to be_installed
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     it "zap method reinstall cask" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       expect(caffeine).to be_installed
 | |
| 
 | |
|       described_class.new(caffeine).zap
 | |
| 
 | |
|       expect(caffeine).not_to be_installed
 | |
|       expect(caffeine.config.appdir.join("Caffeine.app")).not_to be_a_symlink
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "uninstall" do
 | |
|     it "fully uninstalls a Cask" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
|       installer = described_class.new(caffeine)
 | |
| 
 | |
|       installer.install
 | |
|       installer.uninstall
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version, "Caffeine.app")).not_to be_a_directory
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version)).not_to be_a_directory
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine")).not_to be_a_directory
 | |
|     end
 | |
| 
 | |
|     it "uninstalls all versions if force is set" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
|       mutated_version = "#{caffeine.version}.1"
 | |
| 
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version)).to be_a_directory
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", mutated_version)).not_to be_a_directory
 | |
|       FileUtils.mv(Cask::Caskroom.path.join("local-caffeine", caffeine.version),
 | |
|                    Cask::Caskroom.path.join("local-caffeine", mutated_version))
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version)).not_to be_a_directory
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", mutated_version)).to be_a_directory
 | |
| 
 | |
|       described_class.new(caffeine, force: true).uninstall
 | |
| 
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version)).not_to be_a_directory
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine", mutated_version)).not_to be_a_directory
 | |
|       expect(Cask::Caskroom.path.join("local-caffeine")).not_to be_a_directory
 | |
|     end
 | |
| 
 | |
|     context "when loaded from the api, caskfile is required and installed caskfile is invalid" do
 | |
|       let(:path) { cask_path("local-caffeine") }
 | |
|       let(:content) { File.read(path) }
 | |
|       let(:invalid_path) { instance_double(Pathname) }
 | |
| 
 | |
|       before do
 | |
|         allow(invalid_path).to receive(:exist?).and_return(false)
 | |
|       end
 | |
| 
 | |
|       it "uninstalls cask" do
 | |
|         source_caffeine = Cask::CaskLoader.load(path)
 | |
|         expect(Homebrew::API::Cask).to receive(:source_download).twice.and_return(source_caffeine)
 | |
| 
 | |
|         caffeine = Cask::CaskLoader.load(path)
 | |
|         expect(caffeine).to receive(:loaded_from_api?).twice.and_return(true)
 | |
|         expect(caffeine).to receive(:caskfile_only?).twice.and_return(true)
 | |
|         expect(caffeine).to receive(:installed_caskfile).once.and_return(invalid_path)
 | |
| 
 | |
|         described_class.new(caffeine).install
 | |
|         expect(Cask::CaskLoader.load(path)).to be_installed
 | |
| 
 | |
|         described_class.new(caffeine).uninstall
 | |
|         expect(Cask::CaskLoader.load(path)).not_to be_installed
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "uninstall_existing_cask" do
 | |
|     it "uninstalls when cask file is outdated" do
 | |
|       caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
 | |
|       described_class.new(caffeine).install
 | |
| 
 | |
|       expect(Cask::CaskLoader.load(cask_path("local-caffeine"))).to be_installed
 | |
| 
 | |
|       expect(caffeine).to receive(:installed?).once.and_return(true)
 | |
|       outdate_caskfile = cask_path("invalid/invalid-depends-on-macos-bad-release")
 | |
|       expect(caffeine).to receive(:installed_caskfile).once.and_return(outdate_caskfile)
 | |
|       described_class.new(caffeine).uninstall_existing_cask
 | |
| 
 | |
|       expect(Cask::CaskLoader.load(cask_path("local-caffeine"))).not_to be_installed
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "#forbidden_tap_check" do
 | |
|     it "raises on forbidden tap on cask" do
 | |
|       ENV["HOMEBREW_FORBIDDEN_TAPS"] = tap = "homebrew/forbidden"
 | |
| 
 | |
|       cask = Cask::Cask.new("homebrew-forbidden-tap", tap: Tap.fetch(tap)) do
 | |
|         url "file://#{TEST_FIXTURE_DIR}/cask/container.tar.gz"
 | |
|       end
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(cask).forbidden_tap_check
 | |
|       end.to raise_error(Cask::CaskCannotBeInstalledError, /has the tap #{tap}/)
 | |
|     end
 | |
| 
 | |
|     it "raises on forbidden tap on dependency" do
 | |
|       ENV["HOMEBREW_FORBIDDEN_TAPS"] = dep_tap = "homebrew/forbidden"
 | |
|       dep_name = "homebrew-forbidden-dependency-tap"
 | |
|       dep_path = Tap.fetch(dep_tap).new_formula_path(dep_name)
 | |
|       dep_path.parent.mkpath
 | |
|       dep_path.write <<~RUBY
 | |
|         class #{Formulary.class_s(dep_name)} < Formula
 | |
|           url "foo"
 | |
|           version "0.1"
 | |
|         end
 | |
|       RUBY
 | |
|       Formulary.cache.delete(dep_path)
 | |
| 
 | |
|       cask = Cask::Cask.new("homebrew-forbidden-dependent-tap") do
 | |
|         url "file://#{TEST_FIXTURE_DIR}/cask/container.tar.gz"
 | |
|         depends_on formula: dep_name
 | |
|       end
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(cask).forbidden_tap_check
 | |
|       end.to raise_error(Cask::CaskCannotBeInstalledError, /but the #{dep_tap} tap was forbidden/)
 | |
|     ensure
 | |
|       dep_path.parent.parent.rmtree
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "#forbidden_cask_and_formula_check" do
 | |
|     it "raises on forbidden cask" do
 | |
|       ENV["HOMEBREW_FORBIDDEN_CASKS"] = cask_name = "homebrew-forbidden-cask"
 | |
|       cask = Cask::Cask.new(cask_name) do
 | |
|         url "file://#{TEST_FIXTURE_DIR}/cask/container.tar.gz"
 | |
|       end
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(cask).forbidden_cask_and_formula_check
 | |
|       end.to raise_error(Cask::CaskCannotBeInstalledError, /#{cask_name} was forbidden/)
 | |
|     end
 | |
| 
 | |
|     it "raises on forbidden dependency" do
 | |
|       ENV["HOMEBREW_FORBIDDEN_FORMULAE"] = dep_name = "homebrew-forbidden-dependency-formula"
 | |
|       dep_path = CoreTap.instance.new_formula_path(dep_name)
 | |
|       dep_path.write <<~RUBY
 | |
|         class #{Formulary.class_s(dep_name)} < Formula
 | |
|           url "foo"
 | |
|           version "0.1"
 | |
|         end
 | |
|       RUBY
 | |
|       Formulary.cache.delete(dep_path)
 | |
| 
 | |
|       cask = Cask::Cask.new("homebrew-forbidden-dependent-cask") do
 | |
|         url "file://#{TEST_FIXTURE_DIR}/cask/container.tar.gz"
 | |
|         depends_on formula: dep_name
 | |
|       end
 | |
| 
 | |
|       expect do
 | |
|         described_class.new(cask).forbidden_cask_and_formula_check
 | |
|       end.to raise_error(Cask::CaskCannotBeInstalledError, /#{dep_name} formula was forbidden/)
 | |
|     end
 | |
|   end
 | |
| end
 |