41 lines
1.7 KiB
Ruby
41 lines
1.7 KiB
Ruby
require "rubocops/extend/formula_cop"
|
|
|
|
module RuboCop
|
|
module Cop
|
|
module FormulaAudit
|
|
# This cop checks if redundant components are present and other component errors
|
|
#
|
|
# - `url|checksum|mirror` should be inside `stable` block
|
|
# - `head` and `head do` should not be simultaneously present
|
|
# - `bottle :unneeded/:disable` and `bottle do` should not be simultaneously present
|
|
# - `stable do` should not be present without a `head` or `devel` spec
|
|
|
|
class ComponentsRedundancy < FormulaCop
|
|
HEAD_MSG = "`head` and `head do` should not be simultaneously present".freeze
|
|
BOTTLE_MSG = "`bottle :modifier` and `bottle do` should not be simultaneously present".freeze
|
|
STABLE_MSG = "`stable do` should not be present without a `head` or `devel` spec".freeze
|
|
|
|
def audit_formula(_node, _class_node, _parent_class_node, body_node)
|
|
stable_block = find_block(body_node, :stable)
|
|
if stable_block
|
|
[:url, :sha256, :mirror].each do |method_name|
|
|
problem "`#{method_name}` should be put inside `stable` block" if method_called?(body_node, method_name)
|
|
end
|
|
end
|
|
|
|
problem HEAD_MSG if method_called?(body_node, :head) &&
|
|
find_block(body_node, :head)
|
|
|
|
problem BOTTLE_MSG if method_called?(body_node, :bottle) &&
|
|
find_block(body_node, :bottle)
|
|
|
|
return if method_called?(body_node, :head) ||
|
|
find_block(body_node, :head) ||
|
|
find_block(body_node, :devel)
|
|
problem STABLE_MSG if stable_block
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|