83cdc64b40
In FormulaInstaller#install, needed_deps is created without first filtering ARGV for flags like --HEAD. In practice, this means that sometimes needed_deps will contain dependencies that are actually already installed; --HEAD causes Formula#installed_prefix to differ and thus checking Formula#installed? will result in false negatives. This can trigger weird bugs; for example, Homebrew/homebrew#10380, where the "Installing foo" header is displayed even though no dependencies were previously installed. Fix this by filtering ARGV before testing for installed dependencies, and do the same for requirements to maintain symmetry, and because some requiremnts check Formula#installed? as well. Fixes Homebrew/homebrew#10380. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Homebrew
Features, usage and installation instructions are summarized on the homepage.
What Packages Are Available?
- You can browse the Formula directory on GitHub.
- Or type
brew searchfor a list. - Or run
brew serverto browse packages off of a local web server. - Or visit braumeister.org to browse packages online.
More Documentation
brew help or man brew or check our wiki.
Who Are You?
I'm Max Howell and I'm a splendid chap.