da734a30c2
- Fixing the test expected output was unbelievably tedious. - There's been debate about this setting being `false` but in https://github.com/Homebrew/brew/pull/15136#issuecomment-1500063225 we decided that it was worth using the default since RuboCop behaviour changed so we'd have had to do some horrible things to keep it as `false` - https://github.com/Homebrew/brew/pull/15136#issuecomment-1500037278 - and multiple maintainers specify the `--display-cop-names` option to `brew style` themselves since it's clearer what's gone wrong.
45 lines
1.3 KiB
Ruby
45 lines
1.3 KiB
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/class"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::ClassName do
|
|
subject(:cop) { described_class.new }
|
|
|
|
corrected_source = <<~RUBY
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
end
|
|
RUBY
|
|
|
|
it "reports and corrects an offense when using ScriptFileFormula" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < ScriptFileFormula
|
|
^^^^^^^^^^^^^^^^^ FormulaAudit/ClassName: ScriptFileFormula is deprecated, use Formula instead
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
end
|
|
RUBY
|
|
expect_correction(corrected_source)
|
|
end
|
|
|
|
it "reports and corrects an offense when using GithubGistFormula" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < GithubGistFormula
|
|
^^^^^^^^^^^^^^^^^ FormulaAudit/ClassName: GithubGistFormula is deprecated, use Formula instead
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
end
|
|
RUBY
|
|
expect_correction(corrected_source)
|
|
end
|
|
|
|
it "reports and corrects an offense when using AmazonWebServicesFormula" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < AmazonWebServicesFormula
|
|
^^^^^^^^^^^^^^^^^^^^^^^^ FormulaAudit/ClassName: AmazonWebServicesFormula is deprecated, use Formula instead
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
end
|
|
RUBY
|
|
expect_correction(corrected_source)
|
|
end
|
|
end
|