45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
88 lines
2.7 KiB
Ruby
88 lines
2.7 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "compilers"
|
|
|
|
class Keg
|
|
def relocate_dynamic_linkage(relocation)
|
|
# Patching the dynamic linker of glibc breaks it.
|
|
return if name.match? Version.formula_optionally_versioned_regex(:glibc)
|
|
|
|
old_prefix, new_prefix = relocation.replacement_pair_for(:prefix)
|
|
|
|
elf_files.each do |file|
|
|
file.ensure_writable do
|
|
change_rpath(file, old_prefix, new_prefix)
|
|
end
|
|
end
|
|
end
|
|
|
|
def change_rpath(file, old_prefix, new_prefix)
|
|
return false if !file.elf? || !file.dynamic_elf?
|
|
|
|
updated = {}
|
|
old_rpath = file.rpath
|
|
new_rpath = if old_rpath
|
|
rpath = old_rpath.split(":")
|
|
.map { |x| x.sub(old_prefix, new_prefix) }
|
|
.select { |x| x.start_with?(new_prefix, "$ORIGIN") }
|
|
|
|
lib_path = "#{new_prefix}/lib"
|
|
rpath << lib_path unless rpath.include? lib_path
|
|
|
|
# Add GCC's lib directory (as of GCC 12+) to RPATH when there is existing versioned linkage.
|
|
# This prevents broken linkage when pouring bottles built with an old GCC formula.
|
|
unless name.match?(Version.formula_optionally_versioned_regex(:gcc))
|
|
rpath.map! { |rp| rp.sub(%r{lib/gcc/\d+$}, "lib/gcc/current") }
|
|
end
|
|
|
|
rpath.join(":")
|
|
end
|
|
updated[:rpath] = new_rpath if old_rpath != new_rpath
|
|
|
|
old_interpreter = file.interpreter
|
|
new_interpreter = if old_interpreter.nil?
|
|
nil
|
|
elsif File.readable? "#{new_prefix}/lib/ld.so"
|
|
"#{new_prefix}/lib/ld.so"
|
|
else
|
|
old_interpreter.sub old_prefix, new_prefix
|
|
end
|
|
updated[:interpreter] = new_interpreter if old_interpreter != new_interpreter
|
|
|
|
file.patch!(interpreter: updated[:interpreter], rpath: updated[:rpath])
|
|
true
|
|
end
|
|
|
|
def detect_cxx_stdlibs(options = {})
|
|
skip_executables = options.fetch(:skip_executables, false)
|
|
results = Set.new
|
|
elf_files.each do |file|
|
|
next unless file.dynamic_elf?
|
|
next if file.binary_executable? && skip_executables
|
|
|
|
dylibs = file.dynamically_linked_libraries
|
|
results << :libcxx if dylibs.any? { |s| s.include? "libc++.so" }
|
|
results << :libstdcxx if dylibs.any? { |s| s.include? "libstdc++.so" }
|
|
end
|
|
results.to_a
|
|
end
|
|
|
|
def elf_files
|
|
hardlinks = Set.new
|
|
elf_files = []
|
|
path.find do |pn|
|
|
next if pn.symlink? || pn.directory?
|
|
next if !pn.dylib? && !pn.binary_executable?
|
|
|
|
# If we've already processed a file, ignore its hardlinks (which have the
|
|
# same dev ID and inode). This prevents relocations from being performed
|
|
# on a binary more than once.
|
|
next unless hardlinks.add? [pn.stat.dev, pn.stat.ino]
|
|
|
|
elf_files << pn
|
|
end
|
|
elf_files
|
|
end
|
|
end
|