ea4d137e87
While it may suffice to merge string and non-reserved tags by forming a union of all tags of dependencies of the same name, this approach fails to work for the reserved tags. These are now merged such that the most restrictive tag (meaning sometimes an empty tag) is preserved. The previous behavior caused essential dependencies to be omitted and builds to fail in response. E.g., multiple `:fortran` dependencies with tags `[]`, `[:recommended]`, and `[:optional]` would have been expanded and merged to `"gcc"` with tags `[:recommended, :optional]`, causing it to be no longer seen as a required dependency. Closes Homebrew/homebrew#47040. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
126 lines
3.7 KiB
Ruby
126 lines
3.7 KiB
Ruby
require "testing_env"
|
|
require "dependency"
|
|
|
|
class DependableTests < Homebrew::TestCase
|
|
def setup
|
|
@tags = ["foo", "bar", :build]
|
|
@dep = Struct.new(:tags).new(@tags).extend(Dependable)
|
|
end
|
|
|
|
def test_options
|
|
assert_equal %w[--foo --bar].sort, @dep.options.as_flags.sort
|
|
end
|
|
|
|
def test_interrogation
|
|
assert_predicate @dep, :build?
|
|
refute_predicate @dep, :optional?
|
|
refute_predicate @dep, :recommended?
|
|
end
|
|
end
|
|
|
|
class DependencyTests < Homebrew::TestCase
|
|
def test_accepts_single_tag
|
|
dep = Dependency.new("foo", %w[bar])
|
|
assert_equal %w[bar], dep.tags
|
|
end
|
|
|
|
def test_accepts_multiple_tags
|
|
dep = Dependency.new("foo", %w[bar baz])
|
|
assert_equal %w[bar baz].sort, dep.tags.sort
|
|
end
|
|
|
|
def test_preserves_symbol_tags
|
|
dep = Dependency.new("foo", [:build])
|
|
assert_equal [:build], dep.tags
|
|
end
|
|
|
|
def test_accepts_symbol_and_string_tags
|
|
dep = Dependency.new("foo", [:build, "bar"])
|
|
assert_equal [:build, "bar"], dep.tags
|
|
end
|
|
|
|
def test_merge_repeats
|
|
dep = Dependency.new("foo", [:build], nil, "foo")
|
|
dep2 = Dependency.new("foo", ["bar"], nil, "foo2")
|
|
dep3 = Dependency.new("xyz", ["abc"], nil, "foo")
|
|
merged = Dependency.merge_repeats([dep, dep2, dep3])
|
|
assert_equal 2, merged.length
|
|
assert_equal Dependency, merged.first.class
|
|
|
|
foo_named_dep = merged.find {|d| d.name == "foo"}
|
|
assert_equal ["bar"], foo_named_dep.tags
|
|
assert_includes foo_named_dep.option_names, "foo"
|
|
assert_includes foo_named_dep.option_names, "foo2"
|
|
|
|
xyz_named_dep = merged.find {|d| d.name == "xyz"}
|
|
assert_equal ["abc"], xyz_named_dep.tags
|
|
assert_includes xyz_named_dep.option_names, "foo"
|
|
refute_includes xyz_named_dep.option_names, "foo2"
|
|
end
|
|
|
|
def test_merges_necessity_tags
|
|
required_dep = Dependency.new("foo")
|
|
recommended_dep = Dependency.new("foo", [:recommended])
|
|
optional_dep = Dependency.new("foo", [:optional])
|
|
|
|
deps = Dependency.merge_repeats([required_dep, recommended_dep])
|
|
assert_equal deps.count, 1
|
|
assert_predicate deps.first, :required?
|
|
refute_predicate deps.first, :recommended?
|
|
refute_predicate deps.first, :optional?
|
|
|
|
deps = Dependency.merge_repeats([required_dep, optional_dep])
|
|
assert_equal deps.count, 1
|
|
assert_predicate deps.first, :required?
|
|
refute_predicate deps.first, :recommended?
|
|
refute_predicate deps.first, :optional?
|
|
|
|
deps = Dependency.merge_repeats([recommended_dep, optional_dep])
|
|
assert_equal deps.count, 1
|
|
refute_predicate deps.first, :required?
|
|
assert_predicate deps.first, :recommended?
|
|
refute_predicate deps.first, :optional?
|
|
end
|
|
|
|
def test_merges_temporality_tags
|
|
normal_dep = Dependency.new("foo")
|
|
build_dep = Dependency.new("foo", [:build])
|
|
run_dep = Dependency.new("foo", [:run])
|
|
|
|
deps = Dependency.merge_repeats([normal_dep, build_dep])
|
|
assert_equal deps.count, 1
|
|
refute_predicate deps.first, :build?
|
|
refute_predicate deps.first, :run?
|
|
|
|
deps = Dependency.merge_repeats([normal_dep, run_dep])
|
|
assert_equal deps.count, 1
|
|
refute_predicate deps.first, :build?
|
|
refute_predicate deps.first, :run?
|
|
|
|
deps = Dependency.merge_repeats([build_dep, run_dep])
|
|
assert_equal deps.count, 1
|
|
refute_predicate deps.first, :build?
|
|
refute_predicate deps.first, :run?
|
|
end
|
|
|
|
def test_equality
|
|
foo1 = Dependency.new("foo")
|
|
foo2 = Dependency.new("foo")
|
|
bar = Dependency.new("bar")
|
|
assert_equal foo1, foo2
|
|
assert_eql foo1, foo2
|
|
refute_equal foo1, bar
|
|
refute_eql foo1, bar
|
|
foo3 = Dependency.new("foo", [:build])
|
|
refute_equal foo1, foo3
|
|
refute_eql foo1, foo3
|
|
end
|
|
end
|
|
|
|
class TapDependencyTests < Homebrew::TestCase
|
|
def test_option_names
|
|
dep = TapDependency.new("foo/bar/dog")
|
|
assert_equal %w[dog], dep.option_names
|
|
end
|
|
end
|