45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
67 lines
2.0 KiB
Ruby
67 lines
2.0 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
raise "#{__FILE__} must not be loaded via `require`." if $PROGRAM_NAME != __FILE__
|
|
|
|
old_trap = trap("INT") { exit! 130 }
|
|
|
|
require_relative "global"
|
|
require "extend/ENV"
|
|
require "timeout"
|
|
require "formula_assertions"
|
|
require "formula_free_port"
|
|
require "fcntl"
|
|
require "socket"
|
|
require "cli/parser"
|
|
require "dev-cmd/test"
|
|
require "json/add/exception"
|
|
|
|
TEST_TIMEOUT_SECONDS = 5 * 60
|
|
|
|
begin
|
|
ENV.delete("HOMEBREW_FORBID_PACKAGES_FROM_PATHS")
|
|
args = Homebrew::DevCmd::Test.new.args
|
|
Context.current = args.context
|
|
|
|
error_pipe = UNIXSocket.open(ENV.fetch("HOMEBREW_ERROR_PIPE"), &:recv_io)
|
|
error_pipe.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
|
|
|
|
trap("INT", old_trap)
|
|
|
|
if Homebrew::EnvConfig.developer? || ENV["CI"].present?
|
|
raise "Cannot find child processes without `pgrep`, please install!" unless which("pgrep")
|
|
raise "Cannot kill child processes without `pkill`, please install!" unless which("pkill")
|
|
end
|
|
|
|
formula = T.must(args.named.to_resolved_formulae.first)
|
|
formula.extend(Homebrew::Assertions)
|
|
formula.extend(Homebrew::FreePort)
|
|
if args.debug? && !Homebrew::EnvConfig.disable_debrew?
|
|
require "debrew"
|
|
formula.extend(Debrew::Formula)
|
|
end
|
|
|
|
ENV.extend(Stdenv)
|
|
ENV.setup_build_environment(formula:, testing_formula: true)
|
|
|
|
# tests can also return false to indicate failure
|
|
run_test = proc { |_ = nil| raise "test returned false" if formula.run_test(keep_tmp: args.keep_tmp?) == false }
|
|
if args.debug? # --debug is interactive
|
|
run_test.call
|
|
else
|
|
Timeout.timeout(TEST_TIMEOUT_SECONDS, &run_test)
|
|
end
|
|
rescue Exception => e # rubocop:disable Lint/RescueException
|
|
error_pipe.puts e.to_json
|
|
error_pipe.close
|
|
ensure
|
|
pid = Process.pid.to_s
|
|
if which("pgrep") && which("pkill") && system("pgrep", "-P", pid, out: File::NULL)
|
|
$stderr.puts "Killing child processes..."
|
|
system "pkill", "-P", pid
|
|
sleep 1
|
|
system "pkill", "-9", "-P", pid
|
|
end
|
|
exit! 1 if e
|
|
end
|