45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
60 lines
1.8 KiB
Ruby
60 lines
1.8 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "cask_dependent"
|
|
|
|
# Helper functions for dependencies.
|
|
module DependenciesHelpers
|
|
def args_includes_ignores(args)
|
|
includes = [:required?, :recommended?] # included by default
|
|
includes << :build? if args.include_build?
|
|
includes << :test? if args.include_test?
|
|
includes << :optional? if args.include_optional?
|
|
|
|
ignores = []
|
|
ignores << :recommended? if args.skip_recommended?
|
|
ignores << :satisfied? if args.missing?
|
|
|
|
[includes, ignores]
|
|
end
|
|
|
|
def recursive_includes(klass, root_dependent, includes, ignores)
|
|
raise ArgumentError, "Invalid class argument: #{klass}" if klass != Dependency && klass != Requirement
|
|
|
|
cache_key = "recursive_includes_#{includes}_#{ignores}"
|
|
|
|
klass.expand(root_dependent, cache_key:) do |dependent, dep|
|
|
klass.prune if ignores.any? { |ignore| dep.public_send(ignore) }
|
|
klass.prune if includes.none? do |include|
|
|
# Ignore indirect test dependencies
|
|
next if include == :test? && dependent != root_dependent
|
|
|
|
dep.public_send(include)
|
|
end
|
|
|
|
# If a tap isn't installed, we can't find the dependencies of one of
|
|
# its formulae and an exception will be thrown if we try.
|
|
Dependency.keep_but_prune_recursive_deps if klass == Dependency && dep.tap && !dep.tap.installed?
|
|
end
|
|
end
|
|
|
|
def select_includes(dependables, ignores, includes)
|
|
dependables.select do |dep|
|
|
next false if ignores.any? { |ignore| dep.public_send(ignore) }
|
|
|
|
includes.any? { |include| dep.public_send(include) }
|
|
end
|
|
end
|
|
|
|
def dependents(formulae_or_casks)
|
|
formulae_or_casks.map do |formula_or_cask|
|
|
if formula_or_cask.is_a?(Formula)
|
|
formula_or_cask
|
|
else
|
|
CaskDependent.new(formula_or_cask)
|
|
end
|
|
end
|
|
end
|
|
module_function :dependents
|
|
end
|