45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
72 lines
2.2 KiB
Ruby
72 lines
2.2 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "cask_dependent"
|
|
|
|
# Helper functions for installed dependents.
|
|
module InstalledDependents
|
|
module_function
|
|
|
|
# Given an array of kegs, this method will try to find some other kegs
|
|
# or casks that depend on them. If it does, it returns:
|
|
#
|
|
# - some kegs in the passed array that have installed dependents
|
|
# - some installed dependents of those kegs.
|
|
#
|
|
# If it doesn't, it returns nil.
|
|
#
|
|
# Note that nil will be returned if the only installed dependents of the
|
|
# passed kegs are other kegs in the array or casks present in the casks
|
|
# parameter.
|
|
#
|
|
# For efficiency, we don't bother trying to get complete data.
|
|
def find_some_installed_dependents(kegs, casks: [])
|
|
keg_names = kegs.select(&:optlinked?).map(&:name)
|
|
keg_formulae = []
|
|
kegs_by_source = kegs.group_by do |keg|
|
|
# First, attempt to resolve the keg to a formula
|
|
# to get up-to-date name and tap information.
|
|
f = keg.to_formula
|
|
keg_formulae << f
|
|
[f.name, f.tap]
|
|
rescue
|
|
# If the formula for the keg can't be found,
|
|
# fall back to the information in the tab.
|
|
[keg.name, keg.tab.tap]
|
|
end
|
|
|
|
all_required_kegs = Set.new
|
|
all_dependents = []
|
|
|
|
# Don't include dependencies of kegs that were in the given array.
|
|
dependents_to_check = (Formula.installed - keg_formulae) + (Cask::Caskroom.casks - casks)
|
|
|
|
dependents_to_check.each do |dependent|
|
|
required = case dependent
|
|
when Formula
|
|
dependent.missing_dependencies(hide: keg_names)
|
|
when Cask::Cask
|
|
# When checking for cask dependents, we don't care about missing or non-runtime dependencies
|
|
CaskDependent.new(dependent).runtime_dependencies.map(&:to_formula)
|
|
end
|
|
|
|
required_kegs = required.filter_map do |f|
|
|
f_kegs = kegs_by_source[[f.name, f.tap]]
|
|
next unless f_kegs
|
|
|
|
f_kegs.max_by(&:scheme_and_version)
|
|
end
|
|
|
|
next if required_kegs.empty?
|
|
|
|
all_required_kegs += required_kegs
|
|
all_dependents << dependent.to_s
|
|
end
|
|
|
|
return if all_required_kegs.empty?
|
|
return if all_dependents.empty?
|
|
|
|
[all_required_kegs.to_a, all_dependents.sort]
|
|
end
|
|
end
|