5be80a78f6
In a number of Cask specs, the value of the `homepage` stanza is currently set to https://example.com. As of 2018-11-28, the TLS certificate served by example.com seems to be expired, possibly due to an oversight on ICANN’s side. While the certificate is certainly going to be renewed soon, it would be desirable for Homebrew’s test result to be less dependent on ICANN’s actions. This commit changes the homepages of all test Casks to http://brew.sh, whose domain and TLS certificate are both controlled by Homebrew.
75 lines
2.2 KiB
Ruby
75 lines
2.2 KiB
Ruby
require "rubocops/options"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::Options do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "When auditing options" do
|
|
it "reports an offense when using the 32-bit option" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
option "with-32-bit"
|
|
^^^^^^ macOS has been 64-bit only since 10.6 so 32-bit options are deprecated.
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "with universal" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
option :universal
|
|
^^^^^^^^^^^^^^^^^ macOS has been 64-bit only since 10.6 so universal options are deprecated.
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "with deprecated options" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
option :cxx11
|
|
option "examples", "with-examples"
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Options should begin with with/without. Migrate '--examples' with `deprecated_option`.
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "with misc deprecated options" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
option "without-check"
|
|
^^^^^^^^^^^^^^^^^^^^^^ Use '--without-test' instead of '--without-check'. Migrate '--without-check' with `deprecated_option`.
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
end
|
|
|
|
describe RuboCop::Cop::NewFormulaAudit::Options do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "When auditing options for a new formula" do
|
|
it "with deprecated options" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
deprecated_option "examples" => "with-examples"
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ New formulae should not use `deprecated_option`
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "with options" do
|
|
expect_offense(<<~RUBY, "/homebrew-core/")
|
|
class Foo < Formula
|
|
url 'https://brew.sh/foo-1.0.tgz'
|
|
option "with-examples"
|
|
^^^^^^^^^^^^^^^^^^^^^^ Formulae should not have an `option`
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
end
|