
In a number of Cask specs, the value of the `homepage` stanza is currently set to https://example.com. As of 2018-11-28, the TLS certificate served by example.com seems to be expired, possibly due to an oversight on ICANN’s side. While the certificate is certainly going to be renewed soon, it would be desirable for Homebrew’s test result to be less dependent on ICANN’s actions. This commit changes the homepages of all test Casks to http://brew.sh, whose domain and TLS certificate are both controlled by Homebrew.
21 lines
532 B
Ruby
21 lines
532 B
Ruby
require "rubocops/caveats"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::Caveats do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "When auditing caveats" do
|
|
it "When there is setuid mentioned in caveats" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "https://brew.sh/foo"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
def caveats
|
|
"setuid"
|
|
^^^^^^ Don\'t recommend setuid in the caveats, suggest sudo instead.
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
end
|