45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
79 lines
1.6 KiB
Ruby
79 lines
1.6 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "requirement"
|
|
|
|
# An adapter for casks to provide dependency information in a formula-like interface.
|
|
class CaskDependent
|
|
# Defines a dependency on another cask
|
|
class Requirement < ::Requirement
|
|
satisfy(build_env: false) do
|
|
Cask::CaskLoader.load(cask).installed?
|
|
end
|
|
end
|
|
|
|
attr_reader :cask
|
|
|
|
def initialize(cask)
|
|
@cask = cask
|
|
end
|
|
|
|
def name
|
|
@cask.token
|
|
end
|
|
|
|
def full_name
|
|
@cask.full_name
|
|
end
|
|
|
|
def runtime_dependencies
|
|
deps.flat_map { |dep| [dep, *dep.to_formula.runtime_dependencies] }.uniq
|
|
end
|
|
|
|
def deps
|
|
@deps ||= @cask.depends_on.formula.map do |f|
|
|
Dependency.new f
|
|
end
|
|
end
|
|
|
|
def requirements
|
|
@requirements ||= begin
|
|
requirements = []
|
|
dsl_reqs = @cask.depends_on
|
|
|
|
dsl_reqs.arch&.each do |arch|
|
|
arch = if arch[:bits] == 64
|
|
if arch[:type] == :intel
|
|
:x86_64
|
|
else
|
|
:"#{arch[:type]}64"
|
|
end
|
|
elsif arch[:type] == :intel && arch[:bits] == 32
|
|
:i386
|
|
else
|
|
arch[:type]
|
|
end
|
|
requirements << ArchRequirement.new([arch])
|
|
end
|
|
dsl_reqs.cask.each do |cask_ref|
|
|
requirements << CaskDependent::Requirement.new([{ cask: cask_ref }])
|
|
end
|
|
requirements << dsl_reqs.macos if dsl_reqs.macos
|
|
|
|
requirements
|
|
end
|
|
end
|
|
|
|
def recursive_dependencies(&block)
|
|
Dependency.expand(self, &block)
|
|
end
|
|
|
|
def recursive_requirements(&block)
|
|
Requirement.expand(self, &block)
|
|
end
|
|
|
|
def any_version_installed?
|
|
@cask.installed?
|
|
end
|
|
end
|