79db987215
- Apparently the "verified" parameter in the URL (present when a Cask's download URL is not the same as its homepage) shouldn't have the protocol (`https`, `http`) at the front. - Removing this has happened manually in the past, so here's an autocorrecting RuboCop for it.
48 lines
1.1 KiB
Ruby
48 lines
1.1 KiB
Ruby
# typed: false
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/rubocop-cask"
|
|
require "test/rubocops/cask/shared_examples/cask_cop"
|
|
|
|
describe RuboCop::Cop::Cask::Url do
|
|
include CaskCop
|
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "when url 'verified' value does not start with a protocol" do
|
|
let(:source) do
|
|
<<~CASK
|
|
cask "foo" do
|
|
url "https://example.com/download/foo-v1.2.0.dmg",
|
|
verified: "example.com"
|
|
end
|
|
CASK
|
|
end
|
|
|
|
include_examples "does not report any offenses"
|
|
end
|
|
|
|
context "when url 'verified' value starts with a protocol" do
|
|
let(:source) do
|
|
<<~CASK
|
|
cask "foo" do
|
|
url "https://example.com/download/foo-v1.2.0.dmg",
|
|
verified: "https://example.com"
|
|
end
|
|
CASK
|
|
end
|
|
|
|
let(:expected_offenses) do
|
|
[{
|
|
message: "Verified URL parameter value should not start with https:// or http://.",
|
|
severity: :convention,
|
|
line: 3,
|
|
column: 14,
|
|
source: "verified: \"https://example.com\"",
|
|
}]
|
|
end
|
|
|
|
include_examples "reports offenses"
|
|
end
|
|
end
|