3dbb735f3c
This commit solves an issue where the environment handed to
`/usr/sbin/installer` is not the same as the environment used by the
graphical PKG installer.
This is evident in some post-install scripts, e. g. the
`component-10.pkg/Scripts/postinstall` script in the `dymo-label`
cask. The code says:
```
USER_ID=`id -u ${USER}`
launchctl bootstrap gui/$USER_ID /Library/LaunchAgents/com.dymo.dls.webservice.plist
```
The graphical installer will export e. g. `USER=alice`, and
everything works as intended.
However, `brew cask install` does not override `sudo`’s default,
which is `USER=ROOT`. This violates the assumptions in the script.
This commit fixes the issue by configuring `sudo` to override the
following environment variables with the proper user name:
- `LOGNAME`
- `USER`
- `USERNAME`
80 lines
2.2 KiB
Ruby
80 lines
2.2 KiB
Ruby
require "hbc/artifact/abstract_artifact"
|
|
|
|
require "hbc/utils/hash_validator"
|
|
|
|
require "vendor/plist/plist"
|
|
|
|
module Hbc
|
|
module Artifact
|
|
class Pkg < AbstractArtifact
|
|
attr_reader :pkg_relative_path
|
|
|
|
def self.from_args(cask, path, **stanza_options)
|
|
stanza_options.extend(HashValidator).assert_valid_keys(
|
|
:allow_untrusted, :choices
|
|
)
|
|
new(cask, path, **stanza_options)
|
|
end
|
|
|
|
attr_reader :path, :stanza_options
|
|
|
|
def initialize(cask, path, **stanza_options)
|
|
super(cask)
|
|
@path = cask.staged_path.join(path)
|
|
@stanza_options = stanza_options
|
|
end
|
|
|
|
def summarize
|
|
path.relative_path_from(cask.staged_path).to_s
|
|
end
|
|
|
|
def install_phase(**options)
|
|
run_installer(**options)
|
|
end
|
|
|
|
private
|
|
|
|
def run_installer(command: nil, verbose: false, **_options)
|
|
ohai "Running installer for #{cask}; your password may be necessary."
|
|
ohai "Package installers may write to any location; options such as --appdir are ignored."
|
|
unless path.exist?
|
|
raise CaskError, "pkg source file not found: '#{path.relative_path_from(cask.staged_path)}'"
|
|
end
|
|
args = [
|
|
"-pkg", path,
|
|
"-target", "/"
|
|
]
|
|
args << "-verboseR" if verbose
|
|
if stanza_options.fetch(:allow_untrusted, false)
|
|
args << "-allowUntrusted"
|
|
end
|
|
with_choices_file do |choices_path|
|
|
args << "-applyChoiceChangesXML" << choices_path if choices_path
|
|
logged_in_user = Utils.current_user
|
|
env = {
|
|
"LOGNAME" => logged_in_user,
|
|
"USER" => logged_in_user,
|
|
"USERNAME" => logged_in_user,
|
|
}
|
|
command.run!("/usr/sbin/installer", sudo: true, args: args, print_stdout: true, env: env)
|
|
end
|
|
end
|
|
|
|
def with_choices_file
|
|
choices = stanza_options.fetch(:choices, {})
|
|
return yield nil if choices.empty?
|
|
|
|
Tempfile.open(["choices", ".xml"]) do |file|
|
|
begin
|
|
file.write Plist::Emit.dump(choices)
|
|
file.close
|
|
yield file.path
|
|
ensure
|
|
file.unlink
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|