45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
87 lines
2.4 KiB
Ruby
87 lines
2.4 KiB
Ruby
# typed: true # rubocop:disable Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "os/mac/xcode"
|
|
|
|
class DevelopmentTools
|
|
class << self
|
|
alias generic_locate locate
|
|
undef installed?, default_compiler, curl_handles_most_https_certificates?,
|
|
subversion_handles_most_https_certificates?
|
|
|
|
sig { params(tool: T.any(String, Symbol)).returns(T.nilable(Pathname)) }
|
|
def locate(tool)
|
|
(@locate ||= {}).fetch(tool) do |key|
|
|
@locate[key] = if (located_tool = generic_locate(tool))
|
|
located_tool
|
|
else
|
|
path = Utils.popen_read("/usr/bin/xcrun", "-no-cache", "-find", tool, err: :close).chomp
|
|
Pathname.new(path) if File.executable?(path)
|
|
end
|
|
end
|
|
end
|
|
|
|
# Checks if the user has any developer tools installed, either via Xcode
|
|
# or the CLT. Convenient for guarding against formula builds when building
|
|
# is impossible.
|
|
sig { returns(T::Boolean) }
|
|
def installed?
|
|
MacOS::Xcode.installed? || MacOS::CLT.installed?
|
|
end
|
|
|
|
sig { returns(Symbol) }
|
|
def default_compiler
|
|
:clang
|
|
end
|
|
|
|
sig { returns(Version) }
|
|
def ld64_version
|
|
@ld64_version ||= begin
|
|
json = Utils.popen_read("/usr/bin/ld", "-version_details")
|
|
if $CHILD_STATUS.success?
|
|
Version.parse(JSON.parse(json)["version"])
|
|
else
|
|
Version::NULL
|
|
end
|
|
end
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def curl_handles_most_https_certificates?
|
|
# The system Curl is too old for some modern HTTPS certificates on
|
|
# older macOS versions.
|
|
ENV["HOMEBREW_SYSTEM_CURL_TOO_OLD"].nil?
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def subversion_handles_most_https_certificates?
|
|
# The system Subversion is too old for some HTTPS certificates on
|
|
# older macOS versions.
|
|
MacOS.version >= :sierra
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def installation_instructions
|
|
MacOS::CLT.installation_instructions
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def custom_installation_instructions
|
|
<<~EOS
|
|
Install GNU's GCC:
|
|
brew install gcc
|
|
EOS
|
|
end
|
|
|
|
sig { returns(T::Hash[String, T.nilable(String)]) }
|
|
def build_system_info
|
|
build_info = {
|
|
"xcode" => MacOS::Xcode.version.to_s.presence,
|
|
"clt" => MacOS::CLT.version.to_s.presence,
|
|
"preferred_perl" => MacOS.preferred_perl_version,
|
|
}
|
|
generic_build_system_info.merge build_info
|
|
end
|
|
end
|
|
end
|