3dbb735f3c
This commit solves an issue where the environment handed to
`/usr/sbin/installer` is not the same as the environment used by the
graphical PKG installer.
This is evident in some post-install scripts, e. g. the
`component-10.pkg/Scripts/postinstall` script in the `dymo-label`
cask. The code says:
```
USER_ID=`id -u ${USER}`
launchctl bootstrap gui/$USER_ID /Library/LaunchAgents/com.dymo.dls.webservice.plist
```
The graphical installer will export e. g. `USER=alice`, and
everything works as intended.
However, `brew cask install` does not override `sudo`’s default,
which is `USER=ROOT`. This violates the assumptions in the script.
This commit fixes the issue by configuring `sudo` to override the
following environment variables with the proper user name:
- `LOGNAME`
- `USER`
- `USERNAME`
74 lines
2.3 KiB
Ruby
74 lines
2.3 KiB
Ruby
describe Hbc::Artifact::Pkg, :cask do
|
|
let(:cask) { Hbc::CaskLoader.load(cask_path("with-installable")) }
|
|
let(:fake_system_command) { class_double(Hbc::SystemCommand) }
|
|
|
|
before do
|
|
InstallHelper.install_without_artifacts(cask)
|
|
end
|
|
|
|
describe "install_phase" do
|
|
it "runs the system installer on the specified pkgs" do
|
|
pkg = cask.artifacts.find { |a| a.is_a?(described_class) }
|
|
|
|
expect(fake_system_command).to receive(:run!).with(
|
|
"/usr/sbin/installer",
|
|
args: ["-pkg", cask.staged_path.join("MyFancyPkg", "Fancy.pkg"), "-target", "/"],
|
|
sudo: true,
|
|
print_stdout: true,
|
|
env: {
|
|
"LOGNAME" => ENV["USER"],
|
|
"USER" => ENV["USER"],
|
|
"USERNAME" => ENV["USER"],
|
|
},
|
|
)
|
|
|
|
pkg.install_phase(command: fake_system_command)
|
|
end
|
|
end
|
|
|
|
describe "choices" do
|
|
let(:cask) { Hbc::CaskLoader.load(cask_path("with-choices")) }
|
|
|
|
it "passes the choice changes xml to the system installer" do
|
|
pkg = cask.artifacts.find { |a| a.is_a?(described_class) }
|
|
|
|
file = double(path: Pathname.new("/tmp/choices.xml"))
|
|
|
|
expect(file).to receive(:write).with(<<~EOS)
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
|
<plist version="1.0">
|
|
<array>
|
|
\t<dict>
|
|
\t\t<key>attributeSetting</key>
|
|
\t\t<integer>1</integer>
|
|
\t\t<key>choiceAttribute</key>
|
|
\t\t<string>selected</string>
|
|
\t\t<key>choiceIdentifier</key>
|
|
\t\t<string>choice1</string>
|
|
\t</dict>
|
|
</array>
|
|
</plist>
|
|
EOS
|
|
|
|
expect(file).to receive(:close)
|
|
expect(file).to receive(:unlink)
|
|
expect(Tempfile).to receive(:open).and_yield(file)
|
|
|
|
expect(fake_system_command).to receive(:run!).with(
|
|
"/usr/sbin/installer",
|
|
args: ["-pkg", cask.staged_path.join("MyFancyPkg", "Fancy.pkg"), "-target", "/", "-applyChoiceChangesXML", cask.staged_path.join("/tmp/choices.xml")],
|
|
sudo: true,
|
|
print_stdout: true,
|
|
env: {
|
|
"LOGNAME" => ENV["USER"],
|
|
"USER" => ENV["USER"],
|
|
"USERNAME" => ENV["USER"],
|
|
},
|
|
)
|
|
|
|
pkg.install_phase(command: fake_system_command)
|
|
end
|
|
end
|
|
end
|