764d2b2dcc
We have a `HOMEBREW_MACOS_NEWEST_UNSUPPORTED` environment variable and this is used in `MacOSVersion` to determine prerelease versions but we don't have a way of easily determining the newest supported macOS version. `bump-cask-pr` contains logic that assumes the first key/value in `MacOSVersion::SYMBOLS` is the newest macOS version but it recently became clear that this is a prerelease version between WWDC and the subsequent macOS release. Similarly, `dev-cmd/generate-cask-api.rb` tries to compute the newest stable macOS version as `HOMEBREW_MACOS_NEWEST_UNSUPPORTED.to_i - 1` and this will fail if/when we update that variable to `"26"`, as the macOS version before 26 is 15, not 25. This adds a `HOMEBREW_MACOS_NEWEST_SUPPORTED` environment variable, so we have a straightforward way of quickly identifying the newest supported macOS version without having to make potentially unreliable assumptions or do computations to identify the latest non-prerelease `MacOSVersion` value. This also updates the two aforementioned areas to use this environment variable to produce the newest stable macOS version symbol in a more reliable way.
143 lines
4.2 KiB
Ruby
143 lines
4.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "cmd/shared_examples/args_parse"
|
|
require "dev-cmd/bump-cask-pr"
|
|
|
|
RSpec.describe Homebrew::DevCmd::BumpCaskPr do
|
|
subject(:bump_cask_pr) { described_class.new(["test"]) }
|
|
|
|
let(:newest_macos) { MacOSVersion.new(HOMEBREW_MACOS_NEWEST_SUPPORTED).to_sym }
|
|
|
|
let(:c) do
|
|
Cask::Cask.new("test") do
|
|
version "0.0.1,2"
|
|
|
|
url "https://brew.sh/test-0.0.1.dmg"
|
|
name "Test"
|
|
desc "Test cask"
|
|
homepage "https://brew.sh"
|
|
end
|
|
end
|
|
|
|
let(:c_depends_on_intel) do
|
|
Cask::Cask.new("test-depends-on-intel") do
|
|
version "0.0.1,2"
|
|
|
|
url "https://brew.sh/test-0.0.1.dmg"
|
|
name "Test"
|
|
desc "Test cask"
|
|
homepage "https://brew.sh"
|
|
|
|
depends_on arch: :x86_64
|
|
end
|
|
end
|
|
|
|
let(:c_on_system) do
|
|
Cask::Cask.new("test-on-system") do
|
|
os macos: "darwin", linux: "linux"
|
|
|
|
version "0.0.1,2"
|
|
|
|
url "https://brew.sh/test-0.0.1.dmg"
|
|
name "Test"
|
|
desc "Test cask"
|
|
homepage "https://brew.sh"
|
|
end
|
|
end
|
|
|
|
let(:c_on_system_depends_on_intel) do
|
|
Cask::Cask.new("test-on-system-depends-on-intel") do
|
|
os macos: "darwin", linux: "linux"
|
|
|
|
version "0.0.1,2"
|
|
|
|
url "https://brew.sh/test-0.0.1.dmg"
|
|
name "Test"
|
|
desc "Test cask"
|
|
homepage "https://brew.sh"
|
|
|
|
depends_on arch: :x86_64
|
|
end
|
|
end
|
|
|
|
it_behaves_like "parseable arguments"
|
|
|
|
describe "::generate_system_options" do
|
|
# We simulate a macOS version older than the newest, as the method will use
|
|
# the host macOS version instead of the default (the newest macOS version).
|
|
let(:older_macos) { :big_sur }
|
|
|
|
context "when cask does not have on_system blocks/calls or `depends_on arch`" do
|
|
it "returns an array only including macOS/ARM" do
|
|
Homebrew::SimulateSystem.with(os: :linux) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c))
|
|
.to eq([[newest_macos, :arm]])
|
|
end
|
|
|
|
Homebrew::SimulateSystem.with(os: older_macos) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c))
|
|
.to eq([[older_macos, :arm]])
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when cask does not have on_system blocks/calls but has `depends_on arch`" do
|
|
it "returns an array only including macOS/`depends_on arch` value" do
|
|
Homebrew::SimulateSystem.with(os: :linux, arch: :arm) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c_depends_on_intel))
|
|
.to eq([[newest_macos, :intel]])
|
|
end
|
|
|
|
Homebrew::SimulateSystem.with(os: older_macos, arch: :arm) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c_depends_on_intel))
|
|
.to eq([[older_macos, :intel]])
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when cask has on_system blocks/calls but does not have `depends_on arch`" do
|
|
it "returns an array with combinations of `OnSystem::BASE_OS_OPTIONS` and `OnSystem::ARCH_OPTIONS`" do
|
|
Homebrew::SimulateSystem.with(os: :linux) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c_on_system))
|
|
.to eq([
|
|
[newest_macos, :intel],
|
|
[newest_macos, :arm],
|
|
[:linux, :intel],
|
|
[:linux, :arm],
|
|
])
|
|
end
|
|
|
|
Homebrew::SimulateSystem.with(os: older_macos) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c_on_system))
|
|
.to eq([
|
|
[older_macos, :intel],
|
|
[older_macos, :arm],
|
|
[:linux, :intel],
|
|
[:linux, :arm],
|
|
])
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when cask has on_system blocks/calls and `depends_on arch`" do
|
|
it "returns an array with combinations of `OnSystem::BASE_OS_OPTIONS` and `depends_on arch` value" do
|
|
Homebrew::SimulateSystem.with(os: :linux, arch: :arm) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c_on_system_depends_on_intel))
|
|
.to eq([
|
|
[newest_macos, :intel],
|
|
[:linux, :intel],
|
|
])
|
|
end
|
|
|
|
Homebrew::SimulateSystem.with(os: older_macos, arch: :arm) do
|
|
expect(bump_cask_pr.send(:generate_system_options, c_on_system_depends_on_intel))
|
|
.to eq([
|
|
[older_macos, :intel],
|
|
[:linux, :intel],
|
|
])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|