 45978435e7
			
		
	
	
		45978435e7
		
			
		
	
	
	
	
		
			
			- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
		
			
				
	
	
		
			199 lines
		
	
	
		
			4.0 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			199 lines
		
	
	
		
			4.0 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # typed: true # rubocop:todo Sorbet/StrictSigil
 | |
| # frozen_string_literal: true
 | |
| 
 | |
| require "json"
 | |
| 
 | |
| #
 | |
| # {CacheStoreDatabase} acts as an interface to a persistent storage mechanism
 | |
| # residing in the `HOMEBREW_CACHE`.
 | |
| #
 | |
| class CacheStoreDatabase
 | |
|   # Yields the cache store database.
 | |
|   # Closes the database after use if it has been loaded.
 | |
|   #
 | |
|   # @param  [Symbol] type
 | |
|   # @yield  [CacheStoreDatabase] self
 | |
|   def self.use(type)
 | |
|     @db_type_reference_hash ||= {}
 | |
|     @db_type_reference_hash[type] ||= {}
 | |
|     type_ref = @db_type_reference_hash[type]
 | |
| 
 | |
|     type_ref[:count] ||= 0
 | |
|     type_ref[:count]  += 1
 | |
| 
 | |
|     type_ref[:db] ||= CacheStoreDatabase.new(type)
 | |
| 
 | |
|     return_value = yield(type_ref[:db])
 | |
|     if type_ref[:count].positive?
 | |
|       type_ref[:count] -= 1
 | |
|     else
 | |
|       type_ref[:count] = 0
 | |
|     end
 | |
| 
 | |
|     if type_ref[:count].zero?
 | |
|       type_ref[:db].write_if_dirty!
 | |
|       type_ref.delete(:db)
 | |
|     end
 | |
| 
 | |
|     return_value
 | |
|   end
 | |
| 
 | |
|   # Creates a CacheStoreDatabase.
 | |
|   #
 | |
|   # @param  [Symbol] type
 | |
|   # @return [nil]
 | |
|   def initialize(type)
 | |
|     @type = type
 | |
|     @dirty = false
 | |
|   end
 | |
| 
 | |
|   # Sets a value in the underlying database (and creates it if necessary).
 | |
|   def set(key, value)
 | |
|     dirty!
 | |
|     db[key] = value
 | |
|   end
 | |
| 
 | |
|   # Gets a value from the underlying database (if it already exists).
 | |
|   def get(key)
 | |
|     return unless created?
 | |
| 
 | |
|     db[key]
 | |
|   end
 | |
| 
 | |
|   # Deletes a value from the underlying database (if it already exists).
 | |
|   def delete(key)
 | |
|     return unless created?
 | |
| 
 | |
|     dirty!
 | |
|     db.delete(key)
 | |
|   end
 | |
| 
 | |
|   # Deletes all content from the underlying database (if it already exists).
 | |
|   def clear!
 | |
|     return unless created?
 | |
| 
 | |
|     dirty!
 | |
|     db.clear
 | |
|   end
 | |
| 
 | |
|   # Closes the underlying database (if it is created and open).
 | |
|   def write_if_dirty!
 | |
|     return unless dirty?
 | |
| 
 | |
|     cache_path.dirname.mkpath
 | |
|     cache_path.atomic_write(JSON.dump(@db))
 | |
|   end
 | |
| 
 | |
|   # Returns `true` if the cache file has been created for the given `@type`.
 | |
|   #
 | |
|   # @return [Boolean]
 | |
|   def created?
 | |
|     cache_path.exist?
 | |
|   end
 | |
| 
 | |
|   # Returns the modification time of the cache file (if it already exists).
 | |
|   #
 | |
|   # @return [Time]
 | |
|   def mtime
 | |
|     return unless created?
 | |
| 
 | |
|     cache_path.mtime
 | |
|   end
 | |
| 
 | |
|   # Performs a `select` on the underlying database.
 | |
|   #
 | |
|   # @return [Array]
 | |
|   def select(&block)
 | |
|     db.select(&block)
 | |
|   end
 | |
| 
 | |
|   # Returns `true` if the cache is empty.
 | |
|   #
 | |
|   # @return [Boolean]
 | |
|   def empty?
 | |
|     db.empty?
 | |
|   end
 | |
| 
 | |
|   # Performs a `each_key` on the underlying database.
 | |
|   #
 | |
|   # @return [Array]
 | |
|   def each_key(&block)
 | |
|     db.each_key(&block)
 | |
|   end
 | |
| 
 | |
|   private
 | |
| 
 | |
|   # Lazily loaded database in read/write mode. If this method is called, a
 | |
|   # database file will be created in the `HOMEBREW_CACHE` with a name
 | |
|   # corresponding to the `@type` instance variable.
 | |
|   #
 | |
|   # @return [Hash] db
 | |
|   def db
 | |
|     @db ||= begin
 | |
|       JSON.parse(cache_path.read) if created?
 | |
|     rescue JSON::ParserError
 | |
|       nil
 | |
|     end
 | |
|     @db ||= {}
 | |
|   end
 | |
| 
 | |
|   # The path where the database resides in the `HOMEBREW_CACHE` for the given
 | |
|   # `@type`.
 | |
|   #
 | |
|   # @return [String]
 | |
|   def cache_path
 | |
|     HOMEBREW_CACHE/"#{@type}.json"
 | |
|   end
 | |
| 
 | |
|   # Sets that the cache needs to be written to disk.
 | |
|   def dirty!
 | |
|     @dirty = true
 | |
|   end
 | |
| 
 | |
|   # Returns `true` if the cache needs to be written to disk.
 | |
|   #
 | |
|   # @return [Boolean]
 | |
|   def dirty?
 | |
|     @dirty
 | |
|   end
 | |
| end
 | |
| 
 | |
| #
 | |
| # {CacheStore} provides methods to mutate and fetch data from a persistent
 | |
| # storage mechanism.
 | |
| #
 | |
| class CacheStore
 | |
|   # @param  [CacheStoreDatabase] database
 | |
|   # @return [nil]
 | |
|   def initialize(database)
 | |
|     @database = database
 | |
|   end
 | |
| 
 | |
|   # Inserts new values or updates existing cached values to persistent storage.
 | |
|   #
 | |
|   # @abstract
 | |
|   def update!(*)
 | |
|     raise NotImplementedError
 | |
|   end
 | |
| 
 | |
|   # Fetches cached values in persistent storage according to the type of data
 | |
|   # stored.
 | |
|   #
 | |
|   # @abstract
 | |
|   def fetch(*)
 | |
|     raise NotImplementedError
 | |
|   end
 | |
| 
 | |
|   # Deletes data from the cache based on a condition defined in a concrete class.
 | |
|   #
 | |
|   # @abstract
 | |
|   def delete!(*)
 | |
|     raise NotImplementedError
 | |
|   end
 | |
| 
 | |
|   protected
 | |
| 
 | |
|   # @return [CacheStoreDatabase]
 | |
|   attr_reader :database
 | |
| end
 |