45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
89 lines
2.4 KiB
Ruby
89 lines
2.4 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "plist"
|
|
|
|
require "utils/user"
|
|
require "cask/artifact/abstract_artifact"
|
|
require "extend/hash/keys"
|
|
|
|
module Cask
|
|
module Artifact
|
|
# Artifact corresponding to the `pkg` stanza.
|
|
class Pkg < AbstractArtifact
|
|
attr_reader :path, :stanza_options
|
|
|
|
def self.from_args(cask, path, **stanza_options)
|
|
stanza_options.assert_valid_keys(:allow_untrusted, :choices)
|
|
new(cask, path, **stanza_options)
|
|
end
|
|
|
|
def initialize(cask, path, **stanza_options)
|
|
super
|
|
@path = cask.staged_path.join(path)
|
|
@stanza_options = stanza_options
|
|
end
|
|
|
|
def summarize
|
|
path.relative_path_from(cask.staged_path).to_s
|
|
end
|
|
|
|
def install_phase(**options)
|
|
run_installer(**options)
|
|
end
|
|
|
|
private
|
|
|
|
def run_installer(command: nil, verbose: false, **_options)
|
|
ohai "Running installer for #{cask} with sudo; the password may be necessary."
|
|
unless path.exist?
|
|
pkg = path.relative_path_from(cask.staged_path)
|
|
pkgs = Pathname.glob(cask.staged_path/"**"/"*.pkg").map { |path| path.relative_path_from(cask.staged_path) }
|
|
|
|
message = "Could not find PKG source file '#{pkg}'"
|
|
message += ", found #{pkgs.map { |path| "'#{path}'" }.to_sentence} instead" if pkgs.any?
|
|
message += "."
|
|
|
|
raise CaskError, message
|
|
end
|
|
|
|
args = [
|
|
"-pkg", path,
|
|
"-target", "/"
|
|
]
|
|
args << "-verboseR" if verbose
|
|
args << "-allowUntrusted" if stanza_options.fetch(:allow_untrusted, false)
|
|
with_choices_file do |choices_path|
|
|
args << "-applyChoiceChangesXML" << choices_path if choices_path
|
|
env = {
|
|
"LOGNAME" => User.current,
|
|
"USER" => User.current,
|
|
"USERNAME" => User.current,
|
|
}
|
|
command.run!(
|
|
"/usr/sbin/installer",
|
|
sudo: true,
|
|
sudo_as_root: true,
|
|
args:,
|
|
print_stdout: true,
|
|
env:,
|
|
)
|
|
end
|
|
end
|
|
|
|
def with_choices_file
|
|
choices = stanza_options.fetch(:choices, {})
|
|
return yield nil if choices.empty?
|
|
|
|
Tempfile.open(["choices", ".xml"]) do |file|
|
|
file.write Plist::Emit.dump(choices)
|
|
file.close
|
|
yield file.path
|
|
ensure
|
|
file.unlink
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|