1d65c942c3
- I suspect these were copy-pasted from other cops, like I did in https://github.com/Homebrew/brew/pull/14886#discussion_r1125569999. - The "forwardable" require is unnecesary if the cop doesn't `extend Forwardable` and use `def_delegator`. - The "uri" require is unnecessary if the cop doesn't call `URI` methods.
36 lines
1.0 KiB
Ruby
36 lines
1.0 KiB
Ruby
# typed: true
|
|
# frozen_string_literal: true
|
|
|
|
module RuboCop
|
|
module Cop
|
|
module Cask
|
|
# This cop checks for version.before_comma and version.after_comma
|
|
class UrlLegacyCommaSeparators < Base
|
|
include OnUrlStanza
|
|
extend AutoCorrector
|
|
|
|
MSG_CSV = "Use 'version.csv.first' instead of 'version.before_comma' " \
|
|
"and 'version.csv.second' instead of 'version.after_comma'"
|
|
|
|
def on_url_stanza(stanza)
|
|
return if stanza.stanza_node.type == :block
|
|
|
|
url_node = stanza.stanza_node.first_argument
|
|
|
|
legacy_comma_separator_pattern = /version\.(before|after)_comma/
|
|
|
|
url = url_node.source
|
|
|
|
return unless url.match?(legacy_comma_separator_pattern)
|
|
|
|
corrected_url = url.sub("before_comma", "csv.first")&.sub("after_comma", "csv.second")
|
|
|
|
add_offense(url_node.loc.expression, message: format(MSG_CSV, url: url)) do |corrector|
|
|
corrector.replace(url_node.source_range, corrected_url)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|