45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
102 lines
2.9 KiB
Ruby
102 lines
2.9 KiB
Ruby
# typed: true # rubocop:disable Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "os/linux/glibc"
|
|
|
|
class DependencyCollector
|
|
undef gcc_dep_if_needed
|
|
undef glibc_dep_if_needed
|
|
undef init_global_dep_tree_if_needed!
|
|
|
|
sig { params(related_formula_names: T::Set[String]).returns(T.nilable(Dependency)) }
|
|
def gcc_dep_if_needed(related_formula_names)
|
|
# gcc is required for libgcc_s.so.1 if glibc or gcc are too old
|
|
return unless DevelopmentTools.needs_build_formulae?
|
|
return if building_global_dep_tree?
|
|
return if related_formula_names.include?(GCC)
|
|
return if global_dep_tree[GCC]&.intersect?(related_formula_names)
|
|
return unless formula_for(GCC)
|
|
|
|
Dependency.new(GCC, [:implicit])
|
|
end
|
|
|
|
sig { params(related_formula_names: T::Set[String]).returns(T.nilable(Dependency)) }
|
|
def glibc_dep_if_needed(related_formula_names)
|
|
return unless DevelopmentTools.needs_libc_formula?
|
|
return if building_global_dep_tree?
|
|
return if related_formula_names.include?(GLIBC)
|
|
return if global_dep_tree[GLIBC]&.intersect?(related_formula_names)
|
|
return unless formula_for(GLIBC)
|
|
|
|
Dependency.new(GLIBC, [:implicit])
|
|
end
|
|
|
|
private
|
|
|
|
GLIBC = "glibc"
|
|
GCC = OS::LINUX_PREFERRED_GCC_RUNTIME_FORMULA
|
|
|
|
sig { void }
|
|
def init_global_dep_tree_if_needed!
|
|
return unless DevelopmentTools.needs_build_formulae?
|
|
return if building_global_dep_tree?
|
|
return unless global_dep_tree.empty?
|
|
|
|
building_global_dep_tree!
|
|
global_dep_tree[GLIBC] = Set.new(global_deps_for(GLIBC))
|
|
# gcc depends on glibc
|
|
global_dep_tree[GCC] = Set.new([*global_deps_for(GCC), GLIBC, *@@global_dep_tree[GLIBC]])
|
|
built_global_dep_tree!
|
|
end
|
|
|
|
sig { params(name: String).returns(T.nilable(Formula)) }
|
|
def formula_for(name)
|
|
@formula_for ||= {}
|
|
@formula_for[name] ||= Formula[name]
|
|
rescue FormulaUnavailableError
|
|
nil
|
|
end
|
|
|
|
sig { params(name: String).returns(T::Array[String]) }
|
|
def global_deps_for(name)
|
|
@global_deps_for ||= {}
|
|
# Always strip out glibc and gcc from all parts of dependency tree when
|
|
# we're calculating their dependency trees. Other parts of Homebrew will
|
|
# catch any circular dependencies.
|
|
@global_deps_for[name] ||= if (formula = formula_for(name))
|
|
formula.deps.map(&:name).flat_map do |dep|
|
|
[dep, *global_deps_for(dep)].compact
|
|
end.uniq
|
|
else
|
|
[]
|
|
end
|
|
end
|
|
|
|
# Use class variables to avoid this expensive logic needing to be done more
|
|
# than once.
|
|
# rubocop:disable Style/ClassVars
|
|
@@global_dep_tree = {}
|
|
@@building_global_dep_tree = false
|
|
|
|
sig { returns(T::Hash[String, T::Set[String]]) }
|
|
def global_dep_tree
|
|
@@global_dep_tree
|
|
end
|
|
|
|
sig { void }
|
|
def building_global_dep_tree!
|
|
@@building_global_dep_tree = true
|
|
end
|
|
|
|
sig { void }
|
|
def built_global_dep_tree!
|
|
@@building_global_dep_tree = false
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def building_global_dep_tree?
|
|
@@building_global_dep_tree.present?
|
|
end
|
|
# rubocop:enable Style/ClassVars
|
|
end
|