
This adds a `Livecheck::Options` class, which is intended to house various configuration options that are set in `livecheck` blocks, conditionally set by livecheck at runtime, etc. The general idea is that when we add features involving configurations options (e.g., for livecheck, strategies, curl, etc.), we can make changes to `Options` without needing to modify parameters for strategy `find_versions` methods, `Strategy` methods like `page_headers` and `page_content`, etc. This is something that I've been trying to improve over the years and `Options` should help to reduce maintenance overhead in this area while also strengthening type signatures. `Options` replaces the existing `homebrew_curl` option (which related strategies pass to `Strategy` methods and on to `curl_args`) and the new `url_options` (which contains `post_form` or `post_json` values that are used to make `POST` requests). I recently added `url_options` as a temporary way of enabling `POST` support without `Options` but this restores the original `Options`-based implementation. Along the way, I added a `homebrew_curl` parameter to the `url` DSL method, allowing us to set an explicit value in `livecheck` blocks. This is something that we've needed in some cases but I also intend to replace implicit/inferred `homebrew_curl` usage with explicit values in `livecheck` blocks once this is available for use. My intention is to eventually remove the implicit behavior and only rely on explicit values. That will align with how `homebrew_curl` options work for other URLs and makes the behavior clear just from looking at the `livecheck` block. Lastly, this removes the `unused` rest parameter from `find_versions` methods. I originally added `unused` as a way of handling parameters that some `find_versions` methods have but others don't (e.g., `cask` in `ExtractPlist`), as this allowed us to pass various arguments to `find_versions` methods without worrying about whether a particular parameter is available. This isn't an ideal solution and I originally wanted to handle this situation by only passing expected arguments to `find_versions` methods but there was a technical issue standing in the way. I recently found an answer to the issue, so this also replaces the existing `ExtractPlist` special case with generic logic that checks the parameters for a strategy's `find_versions` method and only passes expected arguments. Replacing the aforementioned `find_versions` parameters with `Options` ensures that the remaining parameters are fairly consistent across strategies and any differences are handled by the aforementioned logic. Outside of `ExtractPlist`, the only other difference is that some `find_versions` methods have a `provided_content` parameter but that's currently only used by tests (though it's intended for caching support in the future). I will be renaming that parameter to `content` in an upcoming PR and expanding it to the other strategies, which should make them all consistent outside of `ExtractPlist`.
249 lines
8.2 KiB
Ruby
249 lines
8.2 KiB
Ruby
# typed: strict
|
|
# frozen_string_literal: true
|
|
|
|
require "bundle_version"
|
|
|
|
module Homebrew
|
|
module Livecheck
|
|
module Strategy
|
|
# The {Sparkle} strategy fetches content at a URL and parses it as a
|
|
# Sparkle appcast in XML format.
|
|
#
|
|
# This strategy is not applied automatically and it's necessary to use
|
|
# `strategy :sparkle` in a `livecheck` block to apply it.
|
|
class Sparkle
|
|
# A priority of zero causes livecheck to skip the strategy. We do this
|
|
# for {Sparkle} so we can selectively apply it when appropriate.
|
|
PRIORITY = 0
|
|
|
|
# The `Regexp` used to determine if the strategy applies to the URL.
|
|
URL_MATCH_REGEX = %r{^https?://}i
|
|
|
|
# Common `os` values used in appcasts to refer to macOS.
|
|
APPCAST_MACOS_STRINGS = T.let(["macos", "osx"].freeze, T::Array[String])
|
|
|
|
# Whether the strategy can be applied to the provided URL.
|
|
#
|
|
# @param url [String] the URL to match against
|
|
# @return [Boolean]
|
|
sig { params(url: String).returns(T::Boolean) }
|
|
def self.match?(url)
|
|
URL_MATCH_REGEX.match?(url)
|
|
end
|
|
|
|
Item = Struct.new(
|
|
# @api public
|
|
:title,
|
|
# @api public
|
|
:link,
|
|
# @api public
|
|
:channel,
|
|
# @api public
|
|
:release_notes_link,
|
|
# @api public
|
|
:pub_date,
|
|
# @api public
|
|
:os,
|
|
# @api public
|
|
:url,
|
|
# @api private
|
|
:bundle_version,
|
|
# @api public
|
|
:minimum_system_version,
|
|
keyword_init: true,
|
|
) do
|
|
extend Forwardable
|
|
|
|
# @!attribute [r] version
|
|
# @api public
|
|
delegate version: :bundle_version
|
|
|
|
# @!attribute [r] short_version
|
|
# @api public
|
|
delegate short_version: :bundle_version
|
|
|
|
# @!attribute [r] nice_version
|
|
# @api public
|
|
delegate nice_version: :bundle_version
|
|
end
|
|
|
|
# Identifies version information from a Sparkle appcast.
|
|
#
|
|
# @param content [String] the text of the Sparkle appcast
|
|
# @return [Item, nil]
|
|
sig { params(content: String).returns(T::Array[Item]) }
|
|
def self.items_from_content(content)
|
|
require "rexml/document"
|
|
xml = Xml.parse_xml(content)
|
|
return [] if xml.blank?
|
|
|
|
# Remove prefixes, so we can reliably identify elements and attributes
|
|
xml.root&.each_recursive do |node|
|
|
node.prefix = ""
|
|
node.attributes.each_attribute do |attribute|
|
|
attribute.prefix = ""
|
|
end
|
|
end
|
|
|
|
xml.get_elements("//rss//channel//item").filter_map do |item|
|
|
enclosure = item.elements["enclosure"]
|
|
|
|
if enclosure
|
|
url = enclosure["url"].presence
|
|
short_version = enclosure["shortVersionString"].presence
|
|
version = enclosure["version"].presence
|
|
os = enclosure["os"].presence
|
|
end
|
|
|
|
title = Xml.element_text(item, "title")
|
|
link = Xml.element_text(item, "link")
|
|
url ||= link
|
|
channel = Xml.element_text(item, "channel")
|
|
release_notes_link = Xml.element_text(item, "releaseNotesLink")
|
|
short_version ||= Xml.element_text(item, "shortVersionString")
|
|
version ||= Xml.element_text(item, "version")
|
|
|
|
minimum_system_version_text =
|
|
Xml.element_text(item, "minimumSystemVersion")&.gsub(/\A\D+|\D+\z/, "")
|
|
if minimum_system_version_text.present?
|
|
minimum_system_version = begin
|
|
MacOSVersion.new(minimum_system_version_text)
|
|
rescue MacOSVersion::Error
|
|
nil
|
|
end
|
|
end
|
|
|
|
pub_date = Xml.element_text(item, "pubDate")&.then do |date_string|
|
|
Time.parse(date_string)
|
|
rescue ArgumentError
|
|
# Omit unparsable strings (e.g. non-English dates)
|
|
nil
|
|
end
|
|
|
|
if (match = title&.match(/(\d+(?:\.\d+)*)\s*(\([^)]+\))?\Z/))
|
|
short_version ||= match[1]
|
|
version ||= match[2]
|
|
end
|
|
|
|
bundle_version = BundleVersion.new(short_version, version) if short_version || version
|
|
|
|
data = {
|
|
title:,
|
|
link:,
|
|
channel:,
|
|
release_notes_link:,
|
|
pub_date:,
|
|
os:,
|
|
url:,
|
|
bundle_version:,
|
|
minimum_system_version:,
|
|
}.compact
|
|
next if data.empty?
|
|
|
|
# Set a default `pub_date` (for sorting) if one isn't provided
|
|
data[:pub_date] ||= Time.new(0)
|
|
|
|
Item.new(**data)
|
|
end
|
|
end
|
|
|
|
# Filters out items that aren't suitable for Homebrew.
|
|
#
|
|
# @param items [Array] appcast items
|
|
# @return [Array]
|
|
sig { params(items: T::Array[Item]).returns(T::Array[Item]) }
|
|
def self.filter_items(items)
|
|
items.select do |item|
|
|
# Omit items with an explicit `os` value that isn't macOS
|
|
next false if item.os && APPCAST_MACOS_STRINGS.none?(item.os)
|
|
|
|
# Omit items for prerelease macOS versions
|
|
next false if item.minimum_system_version&.strip_patch&.prerelease?
|
|
|
|
true
|
|
end.compact
|
|
end
|
|
|
|
# Sorts items from newest to oldest.
|
|
#
|
|
# @param items [Array] appcast items
|
|
# @return [Array]
|
|
sig { params(items: T::Array[Item]).returns(T::Array[Item]) }
|
|
def self.sort_items(items)
|
|
items.sort_by { |item| [item.pub_date, item.bundle_version] }
|
|
.reverse
|
|
end
|
|
|
|
# Uses `#items_from_content` to identify versions from the Sparkle
|
|
# appcast content or, if a block is provided, passes the content to
|
|
# the block to handle matching.
|
|
#
|
|
# @param content [String] the content to check
|
|
# @param regex [Regexp, nil] a regex for use in a strategy block
|
|
# @return [Array]
|
|
sig {
|
|
params(
|
|
content: String,
|
|
regex: T.nilable(Regexp),
|
|
block: T.nilable(Proc),
|
|
).returns(T::Array[String])
|
|
}
|
|
def self.versions_from_content(content, regex = nil, &block)
|
|
items = sort_items(filter_items(items_from_content(content)))
|
|
return [] if items.blank?
|
|
|
|
item = items.first
|
|
|
|
if block
|
|
block_return_value = case block.parameters[0]
|
|
when [:opt, :item], [:rest], [:req]
|
|
regex.present? ? yield(item, regex) : yield(item)
|
|
when [:opt, :items]
|
|
regex.present? ? yield(items, regex) : yield(items)
|
|
else
|
|
raise "First argument of Sparkle `strategy` block must be `item` or `items`"
|
|
end
|
|
return Strategy.handle_block_return(block_return_value)
|
|
end
|
|
|
|
version = T.must(item).bundle_version&.nice_version
|
|
version.present? ? [version] : []
|
|
end
|
|
|
|
# Checks the content at the URL for new versions.
|
|
#
|
|
# @param url [String] the URL of the content to check
|
|
# @param regex [Regexp, nil] a regex for use in a strategy block
|
|
# @param options [Options] options to modify behavior
|
|
# @return [Hash]
|
|
sig {
|
|
params(
|
|
url: String,
|
|
regex: T.nilable(Regexp),
|
|
options: Options,
|
|
block: T.nilable(Proc),
|
|
).returns(T::Hash[Symbol, T.untyped])
|
|
}
|
|
def self.find_versions(url:, regex: nil, options: Options.new, &block)
|
|
if regex.present? && block.blank?
|
|
raise ArgumentError,
|
|
"#{Utils.demodulize(name)} only supports a regex when using a `strategy` block"
|
|
end
|
|
|
|
match_data = { matches: {}, regex:, url: }
|
|
|
|
match_data.merge!(Strategy.page_content(url, options:))
|
|
content = match_data.delete(:content)
|
|
return match_data if content.blank?
|
|
|
|
versions_from_content(content, regex, &block).each do |version_text|
|
|
match_data[:matches][version_text] = Version.new(version_text)
|
|
end
|
|
|
|
match_data
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|