
This adds a `Livecheck::Options` class, which is intended to house various configuration options that are set in `livecheck` blocks, conditionally set by livecheck at runtime, etc. The general idea is that when we add features involving configurations options (e.g., for livecheck, strategies, curl, etc.), we can make changes to `Options` without needing to modify parameters for strategy `find_versions` methods, `Strategy` methods like `page_headers` and `page_content`, etc. This is something that I've been trying to improve over the years and `Options` should help to reduce maintenance overhead in this area while also strengthening type signatures. `Options` replaces the existing `homebrew_curl` option (which related strategies pass to `Strategy` methods and on to `curl_args`) and the new `url_options` (which contains `post_form` or `post_json` values that are used to make `POST` requests). I recently added `url_options` as a temporary way of enabling `POST` support without `Options` but this restores the original `Options`-based implementation. Along the way, I added a `homebrew_curl` parameter to the `url` DSL method, allowing us to set an explicit value in `livecheck` blocks. This is something that we've needed in some cases but I also intend to replace implicit/inferred `homebrew_curl` usage with explicit values in `livecheck` blocks once this is available for use. My intention is to eventually remove the implicit behavior and only rely on explicit values. That will align with how `homebrew_curl` options work for other URLs and makes the behavior clear just from looking at the `livecheck` block. Lastly, this removes the `unused` rest parameter from `find_versions` methods. I originally added `unused` as a way of handling parameters that some `find_versions` methods have but others don't (e.g., `cask` in `ExtractPlist`), as this allowed us to pass various arguments to `find_versions` methods without worrying about whether a particular parameter is available. This isn't an ideal solution and I originally wanted to handle this situation by only passing expected arguments to `find_versions` methods but there was a technical issue standing in the way. I recently found an answer to the issue, so this also replaces the existing `ExtractPlist` special case with generic logic that checks the parameters for a strategy's `find_versions` method and only passes expected arguments. Replacing the aforementioned `find_versions` parameters with `Options` ensures that the remaining parameters are fairly consistent across strategies and any differences are handled by the aforementioned logic. Outside of `ExtractPlist`, the only other difference is that some `find_versions` methods have a `provided_content` parameter but that's currently only used by tests (though it's intended for caching support in the future). I will be renaming that parameter to `content` in an upcoming PR and expanding it to the other strategies, which should make them all consistent outside of `ExtractPlist`.
157 lines
5.9 KiB
Ruby
157 lines
5.9 KiB
Ruby
# typed: strict
|
|
# frozen_string_literal: true
|
|
|
|
module Homebrew
|
|
module Livecheck
|
|
module Strategy
|
|
# The {GithubReleases} strategy identifies versions of software at
|
|
# github.com by checking a repository's recent releases using the
|
|
# GitHub API.
|
|
#
|
|
# GitHub URLs take a few different formats:
|
|
#
|
|
# * `https://github.com/example/example/releases/download/1.2.3/example-1.2.3.tar.gz`
|
|
# * `https://github.com/example/example/archive/v1.2.3.tar.gz`
|
|
# * `https://github.com/downloads/example/example/example-1.2.3.tar.gz`
|
|
#
|
|
# {GithubReleases} should only be used when the upstream repository has
|
|
# releases for suitable versions and the strategy is necessary or
|
|
# appropriate (e.g. the formula/cask uses a release asset and the
|
|
# {GithubLatest} strategy isn't sufficient to identify the newest version.
|
|
# The strategy can only be applied by using `strategy :github_releases`
|
|
# in a `livecheck` block.
|
|
#
|
|
# The default regex identifies versions like `1.2.3`/`v1.2.3` in each
|
|
# release's tag or title. This is a common tag format but a modified
|
|
# regex can be provided in a `livecheck` block to override the default
|
|
# if a repository uses a different format (e.g. `1.2.3d`, `1.2.3-4`,
|
|
# etc.).
|
|
#
|
|
# @api public
|
|
class GithubReleases
|
|
NICE_NAME = "GitHub - Releases"
|
|
|
|
# A priority of zero causes livecheck to skip the strategy. We do this
|
|
# for {GithubReleases} so we can selectively apply the strategy using
|
|
# `strategy :github_releases` in a `livecheck` block.
|
|
PRIORITY = 0
|
|
|
|
# The `Regexp` used to determine if the strategy applies to the URL.
|
|
URL_MATCH_REGEX = %r{
|
|
^https?://github\.com
|
|
/(?:downloads/)?(?<username>[^/]+) # The GitHub username
|
|
/(?<repository>[^/]+) # The GitHub repository name
|
|
}ix
|
|
|
|
# The default regex used to identify a version from a tag when a regex
|
|
# isn't provided.
|
|
DEFAULT_REGEX = /v?(\d+(?:\.\d+)+)/i
|
|
|
|
# Keys in the release JSON that could contain the version.
|
|
# The tag name is checked first, to better align with the {Git}
|
|
# strategy.
|
|
VERSION_KEYS = T.let(["tag_name", "name"].freeze, T::Array[String])
|
|
|
|
# Whether the strategy can be applied to the provided URL.
|
|
#
|
|
# @param url [String] the URL to match against
|
|
# @return [Boolean]
|
|
sig { params(url: String).returns(T::Boolean) }
|
|
def self.match?(url)
|
|
URL_MATCH_REGEX.match?(url)
|
|
end
|
|
|
|
# Extracts information from a provided URL and uses it to generate
|
|
# various input values used by the strategy to check for new versions.
|
|
# Some of these values act as defaults and can be overridden in a
|
|
# `livecheck` block.
|
|
#
|
|
# @param url [String] the URL used to generate values
|
|
# @return [Hash]
|
|
sig { params(url: String).returns(T::Hash[Symbol, T.untyped]) }
|
|
def self.generate_input_values(url)
|
|
values = {}
|
|
|
|
match = url.delete_suffix(".git").match(URL_MATCH_REGEX)
|
|
return values if match.blank?
|
|
|
|
values[:url] = "#{GitHub::API_URL}/repos/#{match[:username]}/#{match[:repository]}/releases"
|
|
values[:username] = match[:username]
|
|
values[:repository] = match[:repository]
|
|
|
|
values
|
|
end
|
|
|
|
# Uses a regex to match versions from release JSON or, if a block is
|
|
# provided, passes the JSON to the block to handle matching. With
|
|
# either approach, an array of unique matches is returned.
|
|
#
|
|
# @param content [Array, Hash] array of releases or a single release
|
|
# @param regex [Regexp] a regex used for matching versions in the
|
|
# content
|
|
# @param block [Proc, nil] a block to match the content
|
|
# @return [Array]
|
|
sig {
|
|
params(
|
|
content: T.any(T::Array[T::Hash[String, T.untyped]], T::Hash[String, T.untyped]),
|
|
regex: Regexp,
|
|
block: T.nilable(Proc),
|
|
).returns(T::Array[String])
|
|
}
|
|
def self.versions_from_content(content, regex, &block)
|
|
if block.present?
|
|
block_return_value = yield(content, regex)
|
|
return Strategy.handle_block_return(block_return_value)
|
|
end
|
|
|
|
content = [content] unless content.is_a?(Array)
|
|
content.compact_blank.filter_map do |release|
|
|
next if release["draft"] || release["prerelease"]
|
|
|
|
value = T.let(nil, T.untyped)
|
|
VERSION_KEYS.find do |key|
|
|
match = release[key]&.match(regex)
|
|
next if match.blank?
|
|
|
|
value = match[1]
|
|
end
|
|
value
|
|
end.uniq
|
|
end
|
|
|
|
# Generates the GitHub API URL for the repository's recent releases
|
|
# and identifies versions from the JSON response.
|
|
#
|
|
# @param url [String] the URL of the content to check
|
|
# @param regex [Regexp] a regex used for matching versions in content
|
|
# @param options [Options] options to modify behavior
|
|
# @return [Hash]
|
|
sig {
|
|
params(
|
|
url: String,
|
|
regex: Regexp,
|
|
options: Options,
|
|
block: T.nilable(Proc),
|
|
).returns(T::Hash[Symbol, T.untyped])
|
|
}
|
|
def self.find_versions(url:, regex: DEFAULT_REGEX, options: Options.new, &block)
|
|
match_data = { matches: {}, regex:, url: }
|
|
|
|
generated = generate_input_values(url)
|
|
return match_data if generated.blank?
|
|
|
|
match_data[:url] = generated[:url]
|
|
|
|
releases = GitHub::API.open_rest(generated[:url])
|
|
versions_from_content(releases, regex, &block).each do |match_text|
|
|
match_data[:matches][match_text] = Version.new(match_text)
|
|
end
|
|
|
|
match_data
|
|
end
|
|
end
|
|
end
|
|
GitHubReleases = Homebrew::Livecheck::Strategy::GithubReleases
|
|
end
|
|
end
|