
This adds a `Livecheck::Options` class, which is intended to house various configuration options that are set in `livecheck` blocks, conditionally set by livecheck at runtime, etc. The general idea is that when we add features involving configurations options (e.g., for livecheck, strategies, curl, etc.), we can make changes to `Options` without needing to modify parameters for strategy `find_versions` methods, `Strategy` methods like `page_headers` and `page_content`, etc. This is something that I've been trying to improve over the years and `Options` should help to reduce maintenance overhead in this area while also strengthening type signatures. `Options` replaces the existing `homebrew_curl` option (which related strategies pass to `Strategy` methods and on to `curl_args`) and the new `url_options` (which contains `post_form` or `post_json` values that are used to make `POST` requests). I recently added `url_options` as a temporary way of enabling `POST` support without `Options` but this restores the original `Options`-based implementation. Along the way, I added a `homebrew_curl` parameter to the `url` DSL method, allowing us to set an explicit value in `livecheck` blocks. This is something that we've needed in some cases but I also intend to replace implicit/inferred `homebrew_curl` usage with explicit values in `livecheck` blocks once this is available for use. My intention is to eventually remove the implicit behavior and only rely on explicit values. That will align with how `homebrew_curl` options work for other URLs and makes the behavior clear just from looking at the `livecheck` block. Lastly, this removes the `unused` rest parameter from `find_versions` methods. I originally added `unused` as a way of handling parameters that some `find_versions` methods have but others don't (e.g., `cask` in `ExtractPlist`), as this allowed us to pass various arguments to `find_versions` methods without worrying about whether a particular parameter is available. This isn't an ideal solution and I originally wanted to handle this situation by only passing expected arguments to `find_versions` methods but there was a technical issue standing in the way. I recently found an answer to the issue, so this also replaces the existing `ExtractPlist` special case with generic logic that checks the parameters for a strategy's `find_versions` method and only passes expected arguments. Replacing the aforementioned `find_versions` parameters with `Options` ensures that the remaining parameters are fairly consistent across strategies and any differences are handled by the aforementioned logic. Outside of `ExtractPlist`, the only other difference is that some `find_versions` methods have a `provided_content` parameter but that's currently only used by tests (though it's intended for caching support in the future). I will be renaming that parameter to `content` in an upcoming PR and expanding it to the other strategies, which should make them all consistent outside of `ExtractPlist`.
124 lines
4.4 KiB
Ruby
124 lines
4.4 KiB
Ruby
# typed: strict
|
|
# frozen_string_literal: true
|
|
|
|
require "bundle_version"
|
|
require "unversioned_cask_checker"
|
|
|
|
module Homebrew
|
|
module Livecheck
|
|
module Strategy
|
|
# The {ExtractPlist} strategy downloads the file at a URL and extracts
|
|
# versions from contained `.plist` files using {UnversionedCaskChecker}.
|
|
#
|
|
# In practice, this strategy operates by downloading very large files,
|
|
# so it's both slow and data-intensive. As such, the {ExtractPlist}
|
|
# strategy should only be used as an absolute last resort.
|
|
#
|
|
# This strategy is not applied automatically and it's necessary to use
|
|
# `strategy :extract_plist` in a `livecheck` block to apply it.
|
|
class ExtractPlist
|
|
# A priority of zero causes livecheck to skip the strategy. We do this
|
|
# for {ExtractPlist} so we can selectively apply it when appropriate.
|
|
PRIORITY = 0
|
|
|
|
# The `Regexp` used to determine if the strategy applies to the URL.
|
|
URL_MATCH_REGEX = %r{^https?://}i
|
|
|
|
# Whether the strategy can be applied to the provided URL.
|
|
#
|
|
# @param url [String] the URL to match against
|
|
# @return [Boolean]
|
|
sig { params(url: String).returns(T::Boolean) }
|
|
def self.match?(url)
|
|
URL_MATCH_REGEX.match?(url)
|
|
end
|
|
|
|
Item = Struct.new(
|
|
:bundle_version,
|
|
keyword_init: true,
|
|
) do
|
|
extend Forwardable
|
|
|
|
# @!attribute [r] version
|
|
# @api public
|
|
delegate version: :bundle_version
|
|
|
|
# @!attribute [r] short_version
|
|
# @api public
|
|
delegate short_version: :bundle_version
|
|
end
|
|
|
|
# Identify versions from `Item`s produced using
|
|
# {UnversionedCaskChecker} version information.
|
|
#
|
|
# @param items [Hash] a hash of `Item`s containing version information
|
|
# @param regex [Regexp, nil] a regex for use in a strategy block
|
|
# @return [Array]
|
|
sig {
|
|
params(
|
|
items: T::Hash[String, Item],
|
|
regex: T.nilable(Regexp),
|
|
block: T.nilable(Proc),
|
|
).returns(T::Array[String])
|
|
}
|
|
def self.versions_from_items(items, regex = nil, &block)
|
|
if block
|
|
block_return_value = regex.present? ? yield(items, regex) : yield(items)
|
|
return Strategy.handle_block_return(block_return_value)
|
|
end
|
|
|
|
items.filter_map do |_key, item|
|
|
item.bundle_version.nice_version
|
|
end.uniq
|
|
end
|
|
|
|
# Uses {UnversionedCaskChecker} on the provided cask to identify
|
|
# versions from `plist` files.
|
|
#
|
|
# @param cask [Cask::Cask] the cask to check for version information
|
|
# @param url [String, nil] an alternative URL to check for version
|
|
# information
|
|
# @param regex [Regexp, nil] a regex for use in a strategy block
|
|
# @param options [Options] options to modify behavior
|
|
# @return [Hash]
|
|
sig {
|
|
params(
|
|
cask: Cask::Cask,
|
|
url: T.nilable(String),
|
|
regex: T.nilable(Regexp),
|
|
options: Options,
|
|
block: T.nilable(Proc),
|
|
).returns(T::Hash[Symbol, T.untyped])
|
|
}
|
|
def self.find_versions(cask:, url: nil, regex: nil, options: Options.new, &block)
|
|
if regex.present? && block.blank?
|
|
raise ArgumentError,
|
|
"#{Utils.demodulize(name)} only supports a regex when using a `strategy` block"
|
|
end
|
|
raise ArgumentError, "The #{Utils.demodulize(name)} strategy only supports casks." unless T.unsafe(cask)
|
|
|
|
match_data = { matches: {}, regex:, url: }
|
|
|
|
unversioned_cask_checker = if url.present? && url != cask.url.to_s
|
|
# Create a copy of the `cask` that uses the `livecheck` block URL
|
|
cask_copy = Cask::CaskLoader.load(cask.sourcefile_path)
|
|
cask_copy.allow_reassignment = true
|
|
cask_copy.url url
|
|
UnversionedCaskChecker.new(cask_copy)
|
|
else
|
|
UnversionedCaskChecker.new(cask)
|
|
end
|
|
|
|
items = unversioned_cask_checker.all_versions.transform_values { |v| Item.new(bundle_version: v) }
|
|
|
|
versions_from_items(items, regex, &block).each do |version_text|
|
|
match_data[:matches][version_text] = Version.new(version_text)
|
|
end
|
|
|
|
match_data
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|