admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
brew/Library/Homebrew/test/rubocops
History
Rylan Polster 0faf17b1e6 use safe_popen_read instead of popen_read 
RuboCop requires using Utils.safe_popen_read and Utils.safe_popen_write
instead of Utils.popen_read and Utils.popen_write respectively.

Using the "safe" version means that an error will be shown if the
command fails. Previously, when using `popen_read`, a failed command can
go unnoticed and have negative consequences that go undetected (as
happened for pipend in
https://github.com/Homebrew/homebrew-core/pull/55682)

RuboCop does not require Utils.safe_popen_read in a test do block
because there can be some legitimate uses for Utils.popen_read in these
cases.
2020-06-23 13:57:33 -04:00
..
cask
Update Gems.
2019-10-03 09:22:44 +02:00
caveats_spec.rb
…
checksum_spec.rb
…
class_spec.rb
rubocops/class: rename, move cops, readd strict.
2020-04-13 16:01:25 +01:00
components_order_spec.rb
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
components_redundancy_spec.rb
…
conflicts_spec.rb
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
dependency_order_spec.rb
audit: add uses_from_macos dependency ordering
2020-01-12 11:12:27 -08:00
files_spec.rb
Move file mode audit to RuboCop.
2020-04-18 15:44:24 +01:00
formula_desc_spec.rb
rubocops/formula_desc: merge cops, slim whitelist.
2020-04-13 16:01:25 +01:00
homepage_spec.rb
brew style --fix
2020-06-02 09:49:23 +01:00
keg_only_spec.rb
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
lines_spec.rb
use safe_popen_read instead of popen_read
2020-06-23 13:57:33 -04:00
options_spec.rb
audit: add "homebrew/core" for relevant checks
2020-01-08 15:38:48 -05:00
patches_spec.rb
Fix rubocop-performance brew style.
2020-05-22 08:52:26 +01:00
text_spec.rb
formula: add std_cargo_args
2020-06-22 14:39:49 +02:00
urls_spec.rb
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
uses_from_macos_spec.rb
rubocops: test whitelists.
2020-04-12 14:17:05 +01:00
version_spec.rb
audit: Port version checks that do not rely on Formula state to RuboCop and add tests
2020-05-18 10:12:13 -05:00