 d768b6649a
			
		
	
	
		d768b6649a
		
	
	
	
	
		
			
			- Extract the json reading from the json merging: it makes the code hard to understand. This helps for the separation of concerns: the jsons are read in one method; and merged in a second one - Added a first test to check the merge function No change in behaviour was done, this change is just there to increase code coverage and to prepare for #9315
		
			
				
	
	
		
			197 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			197 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # typed: false
 | |
| # frozen_string_literal: true
 | |
| 
 | |
| require "cmd/shared_examples/args_parse"
 | |
| require "dev-cmd/bottle"
 | |
| 
 | |
| describe "Homebrew.bottle_args" do
 | |
|   it_behaves_like "parseable arguments"
 | |
| end
 | |
| 
 | |
| describe "brew bottle", :integration_test do
 | |
|   it "builds a bottle for the given Formula" do
 | |
|     # create stub patchelf
 | |
|     if OS.linux?
 | |
|       setup_test_formula "patchelf"
 | |
|       patchelf = HOMEBREW_CELLAR/"patchelf/1.0/bin/patchelf"
 | |
|       patchelf.dirname.mkpath
 | |
|       patchelf.write <<~EOS
 | |
|         #!/bin/sh
 | |
|         exit 0
 | |
|       EOS
 | |
|       FileUtils.chmod "+x", patchelf
 | |
|       FileUtils.ln_s patchelf, HOMEBREW_PREFIX/"bin/patchelf"
 | |
|     end
 | |
| 
 | |
|     install_test_formula "testball", build_bottle: true
 | |
| 
 | |
|     # `brew bottle` should not fail with dead symlink
 | |
|     # https://github.com/Homebrew/legacy-homebrew/issues/49007
 | |
|     (HOMEBREW_CELLAR/"testball/0.1").cd do
 | |
|       FileUtils.ln_s "not-exist", "symlink"
 | |
|     end
 | |
| 
 | |
|     begin
 | |
|       expect { brew "bottle", "--no-rebuild", "testball" }
 | |
|         .to output(/testball--0\.1.*\.bottle\.tar\.gz/).to_stdout
 | |
|         .and not_to_output.to_stderr
 | |
|         .and be_a_success
 | |
|     ensure
 | |
|       FileUtils.rm_f Dir.glob("testball--0.1*.bottle.tar.gz")
 | |
|     end
 | |
|   end
 | |
| end
 | |
| 
 | |
| describe Homebrew do
 | |
|   subject(:homebrew) { described_class }
 | |
| 
 | |
|   def stub_hash(parameters)
 | |
|     <<~EOS
 | |
|       {
 | |
|         "#{parameters[:name]}":{
 | |
|            "formula":{
 | |
|               "pkg_version":"#{parameters[:version]}",
 | |
|               "path":"#{parameters[:path]}"
 | |
|            },
 | |
|            "bottle":{
 | |
|               "root_url":"https://homebrew.bintray.com/bottles",
 | |
|               "prefix":"/usr/local",
 | |
|               "cellar":"#{parameters[:cellar]}",
 | |
|               "rebuild":0,
 | |
|               "tags":{
 | |
|                  "#{parameters[:os]}":{
 | |
|                     "filename":"#{parameters[:filename]}",
 | |
|                     "local_filename":"#{parameters[:local_filename]}",
 | |
|                     "sha256":"#{parameters[:sha256]}"
 | |
|                  }
 | |
|               }
 | |
|            },
 | |
|            "bintray":{
 | |
|               "package":"#{parameters[:name]}",
 | |
|               "repository":"bottles"
 | |
|            }
 | |
|         }
 | |
|       }
 | |
|     EOS
 | |
|   end
 | |
| 
 | |
|   let(:hello_hash_big_sur) {
 | |
|     JSON.parse(
 | |
|       stub_hash(
 | |
|         {
 | |
|           "name":           "hello",
 | |
|           "version":        "1.0",
 | |
|           "path":           "/home/hello.rb",
 | |
|           "cellar":         "any_skip_relocation",
 | |
|           "os":             "big_sur",
 | |
|           "filename":       "hello-1.0.big_sur.bottle.tar.gz",
 | |
|           "local_filename": "hello--1.0.big_sur.bottle.tar.gz",
 | |
|           "sha256":         "a0af7dcbb5c83f6f3f7ecd507c2d352c1a018f894d51ad241ce8492fa598010f",
 | |
|         },
 | |
|       ),
 | |
|     )
 | |
|   }
 | |
|   let(:hello_hash_catalina) {
 | |
|     JSON.parse(
 | |
|       stub_hash(
 | |
|         {
 | |
|           "name":           "hello",
 | |
|           "version":        "1.0",
 | |
|           "path":           "/home/hello.rb",
 | |
|           "cellar":         "any_skip_relocation",
 | |
|           "os":             "catalina",
 | |
|           "filename":       "hello-1.0.catalina.bottle.tar.gz",
 | |
|           "local_filename": "hello--1.0.catalina.bottle.tar.gz",
 | |
|           "sha256":         "5334dd344986e46b2aa4f0471cac7b0914bd7de7cb890a34415771788d03f2ac",
 | |
|         },
 | |
|       ),
 | |
|     )
 | |
|   }
 | |
|   let(:unzip_hash_big_sur) {
 | |
|     JSON.parse(
 | |
|       stub_hash(
 | |
|         {
 | |
|           "name":           "unzip",
 | |
|           "version":        "2.0",
 | |
|           "path":           "/home/unzip.rb",
 | |
|           "cellar":         "any_skip_relocation",
 | |
|           "os":             "big_sur",
 | |
|           "filename":       "unzip-2.0.big_sur.bottle.tar.gz",
 | |
|           "local_filename": "unzip--2.0.big_sur.bottle.tar.gz",
 | |
|           "sha256":         "16cf230afdfcb6306c208d169549cf8773c831c8653d2c852315a048960d7e72",
 | |
|         },
 | |
|       ),
 | |
|     )
 | |
|   }
 | |
|   let(:unzip_hash_catalina) {
 | |
|     JSON.parse(
 | |
|       stub_hash(
 | |
|         {
 | |
|           "name":           "unzip",
 | |
|           "version":        "2.0",
 | |
|           "path":           "/home/unzip.rb",
 | |
|           "cellar":         "any",
 | |
|           "os":             "catalina",
 | |
|           "filename":       "unzip-2.0.catalina.bottle.tar.gz",
 | |
|           "local_filename": "unzip--2.0.catalina.bottle.tar.gz",
 | |
|           "sha256":         "d9cc50eec8ac243148a121049c236cba06af4a0b1156ab397d0a2850aa79c137",
 | |
|         },
 | |
|       ),
 | |
|     )
 | |
|   }
 | |
| 
 | |
|   specify "::parse_json_files" do
 | |
|     Tempfile.open("hello--1.0.big_sur.bottle.json") do |f|
 | |
|       f.write(
 | |
|         stub_hash(
 | |
|           {
 | |
|             "name":           "hello",
 | |
|             "version":        "1.0",
 | |
|             "path":           "/home/hello.rb",
 | |
|             "cellar":         "any_skip_relocation",
 | |
|             "os":             "big_sur",
 | |
|             "filename":       "hello-1.0.big_sur.bottle.tar.gz",
 | |
|             "local_filename": "hello--1.0.big_sur.bottle.tar.gz",
 | |
|             "sha256":         "a0af7dcbb5c83f6f3f7ecd507c2d352c1a018f894d51ad241ce8492fa598010f",
 | |
|           },
 | |
|         ),
 | |
|       )
 | |
|       f.close
 | |
|       expect(
 | |
|         homebrew.parse_json_files([f.path]).first["hello"]["bottle"]["tags"]["big_sur"]["filename"],
 | |
|       ).to eq("hello-1.0.big_sur.bottle.tar.gz")
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   specify "::merge_json_files" do
 | |
|     bottles_hash = homebrew.merge_json_files(
 | |
|       [hello_hash_big_sur, hello_hash_catalina, unzip_hash_big_sur, unzip_hash_catalina],
 | |
|     )
 | |
| 
 | |
|     hello_hash = bottles_hash["hello"]
 | |
|     expect(hello_hash["bottle"]["cellar"]).to eq("any_skip_relocation")
 | |
|     expect(hello_hash["bottle"]["tags"]["big_sur"]["filename"]).to eq("hello-1.0.big_sur.bottle.tar.gz")
 | |
|     expect(hello_hash["bottle"]["tags"]["big_sur"]["local_filename"]).to eq("hello--1.0.big_sur.bottle.tar.gz")
 | |
|     expect(hello_hash["bottle"]["tags"]["big_sur"]["sha256"]).to eq(
 | |
|       "a0af7dcbb5c83f6f3f7ecd507c2d352c1a018f894d51ad241ce8492fa598010f",
 | |
|     )
 | |
|     expect(hello_hash["bottle"]["tags"]["catalina"]["filename"]).to eq("hello-1.0.catalina.bottle.tar.gz")
 | |
|     expect(hello_hash["bottle"]["tags"]["catalina"]["local_filename"]).to eq("hello--1.0.catalina.bottle.tar.gz")
 | |
|     expect(hello_hash["bottle"]["tags"]["catalina"]["sha256"]).to eq(
 | |
|       "5334dd344986e46b2aa4f0471cac7b0914bd7de7cb890a34415771788d03f2ac",
 | |
|     )
 | |
|     unzip_hash = bottles_hash["unzip"]
 | |
|     expect(unzip_hash["bottle"]["cellar"]).to eq("any")
 | |
|     expect(unzip_hash["bottle"]["tags"]["big_sur"]["filename"]).to eq("unzip-2.0.big_sur.bottle.tar.gz")
 | |
|     expect(unzip_hash["bottle"]["tags"]["big_sur"]["local_filename"]).to eq("unzip--2.0.big_sur.bottle.tar.gz")
 | |
|     expect(unzip_hash["bottle"]["tags"]["big_sur"]["sha256"]).to eq(
 | |
|       "16cf230afdfcb6306c208d169549cf8773c831c8653d2c852315a048960d7e72",
 | |
|     )
 | |
|     expect(unzip_hash["bottle"]["tags"]["catalina"]["filename"]).to eq("unzip-2.0.catalina.bottle.tar.gz")
 | |
|     expect(unzip_hash["bottle"]["tags"]["catalina"]["local_filename"]).to eq("unzip--2.0.catalina.bottle.tar.gz")
 | |
|     expect(unzip_hash["bottle"]["tags"]["catalina"]["sha256"]).to eq(
 | |
|       "d9cc50eec8ac243148a121049c236cba06af4a0b1156ab397d0a2850aa79c137",
 | |
|     )
 | |
|   end
 | |
| end
 |