5be80a78f6
In a number of Cask specs, the value of the `homepage` stanza is currently set to https://example.com. As of 2018-11-28, the TLS certificate served by example.com seems to be expired, possibly due to an oversight on ICANN’s side. While the certificate is certainly going to be renewed soon, it would be desirable for Homebrew’s test result to be less dependent on ICANN’s actions. This commit changes the homepages of all test Casks to http://brew.sh, whose domain and TLS certificate are both controlled by Homebrew.
100 lines
3.1 KiB
Ruby
100 lines
3.1 KiB
Ruby
require "rubocops/dependency_order"
|
|
|
|
describe RuboCop::Cop::FormulaAudit::DependencyOrder do
|
|
subject(:cop) { described_class.new }
|
|
|
|
context "depends_on" do
|
|
it "wrong conditional depends_on order" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "foo" => :optional
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dependency "foo" (line 5) should be put before dependency "apple" (line 4)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "wrong alphabetical depends_on order" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
depends_on "foo"
|
|
depends_on "bar"
|
|
^^^^^^^^^^^^^^^^ dependency "bar" (line 5) should be put before dependency "foo" (line 4)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "supports requirement constants" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
depends_on FooRequirement
|
|
depends_on "bar"
|
|
^^^^^^^^^^^^^^^^ dependency "bar" (line 5) should be put before dependency "FooRequirement" (line 4)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "wrong conditional depends_on order with block" do
|
|
expect_offense(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
head do
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "bar"
|
|
^^^^^^^^^^^^^^^^ dependency "bar" (line 6) should be put before dependency "apple" (line 5)
|
|
depends_on "foo" => :optional
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dependency "foo" (line 7) should be put before dependency "apple" (line 5)
|
|
end
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "foo" => :optional
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ dependency "foo" (line 10) should be put before dependency "apple" (line 9)
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "correct depends_on order for multiple tags" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
depends_on "bar" => [:build, :test]
|
|
depends_on "foo" => :build
|
|
depends_on "apple"
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
|
|
context "autocorrect" do
|
|
it "wrong conditional depends_on order" do
|
|
source = <<~RUBY
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
depends_on "apple" if build.with? "foo"
|
|
depends_on "foo" => :optional
|
|
end
|
|
RUBY
|
|
|
|
correct_source = <<~RUBY
|
|
class Foo < Formula
|
|
homepage "https://brew.sh"
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
depends_on "foo" => :optional
|
|
depends_on "apple" if build.with? "foo"
|
|
end
|
|
RUBY
|
|
|
|
corrected_source = autocorrect_source(source)
|
|
expect(corrected_source).to eq(correct_source)
|
|
end
|
|
end
|
|
end
|