45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
46 lines
1.2 KiB
Ruby
46 lines
1.2 KiB
Ruby
# typed: true # rubocop:disable Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "system_command"
|
|
|
|
module SystemConfig
|
|
class << self
|
|
include SystemCommand::Mixin
|
|
|
|
undef describe_clang
|
|
|
|
sig { returns(String) }
|
|
def describe_clang
|
|
return "N/A" if clang.null?
|
|
|
|
clang_build_info = clang_build.null? ? "(parse error)" : clang_build
|
|
"#{clang} build #{clang_build_info}"
|
|
end
|
|
|
|
def xcode
|
|
@xcode ||= if MacOS::Xcode.installed?
|
|
xcode = MacOS::Xcode.version.to_s
|
|
xcode += " => #{MacOS::Xcode.prefix}" unless MacOS::Xcode.default_prefix?
|
|
xcode
|
|
end
|
|
end
|
|
|
|
def clt
|
|
@clt ||= MacOS::CLT.version if MacOS::CLT.installed?
|
|
end
|
|
|
|
def core_tap_config(out = $stdout)
|
|
dump_tap_config(CoreTap.instance, out)
|
|
dump_tap_config(CoreCaskTap.instance, out)
|
|
end
|
|
|
|
def dump_verbose_config(out = $stdout)
|
|
dump_generic_verbose_config(out)
|
|
out.puts "macOS: #{MacOS.full_version}-#{kernel}"
|
|
out.puts "CLT: #{clt || "N/A"}"
|
|
out.puts "Xcode: #{xcode || "N/A"}"
|
|
out.puts "Rosetta 2: #{Hardware::CPU.in_rosetta2?}" if Hardware::CPU.physical_cpu_arm64?
|
|
end
|
|
end
|
|
end
|