45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
40 lines
1.1 KiB
Ruby
40 lines
1.1 KiB
Ruby
# typed: true # rubocop:disable Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
module Readall
|
|
class << self
|
|
undef valid_casks?
|
|
|
|
def valid_casks?(tap, os_name: nil, arch: Hardware::CPU.type)
|
|
return true if os_name == :linux
|
|
|
|
current_macos_version = if os_name.is_a?(Symbol)
|
|
MacOSVersion.from_symbol(os_name)
|
|
else
|
|
MacOS.version
|
|
end
|
|
|
|
success = T.let(true, T::Boolean)
|
|
tap.cask_files.each do |file|
|
|
cask = Cask::CaskLoader.load(file)
|
|
|
|
# Fine to have missing URLs for unsupported macOS
|
|
macos_req = cask.depends_on.macos
|
|
next if macos_req&.version && Array(macos_req.version).none? do |macos_version|
|
|
current_macos_version.compare(macos_req.comparator, macos_version)
|
|
end
|
|
|
|
raise "Missing URL" if cask.url.nil?
|
|
rescue Interrupt
|
|
raise
|
|
rescue Exception => e # rubocop:disable Lint/RescueException
|
|
os_and_arch = "macOS #{current_macos_version} on #{arch}"
|
|
onoe "Invalid cask (#{os_and_arch}): #{file}"
|
|
$stderr.puts e
|
|
success = false
|
|
end
|
|
success
|
|
end
|
|
end
|
|
end
|